Skip to content

Commit 442596e

Browse files
committed
Fix getPortalPlacement in PortalPlacementContext
1 parent 5bee3f4 commit 442596e

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

  • packages/react-select/src/components

packages/react-select/src/components/Menu.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,9 @@ export const menuCSS = ({
258258
zIndex: 1,
259259
});
260260

261-
const PortalPlacementContext = createContext<() => void>(() => { });
261+
const PortalPlacementContext = createContext<{
262+
getPortalPlacement?: (() => void) | null,
263+
}>({ getPortalPlacement: null });
262264

263265
// NOTE: internal only
264266
export class MenuPlacer extends Component<MenuPlacerProps, MenuState> {
@@ -277,7 +279,6 @@ export class MenuPlacer extends Component<MenuPlacerProps, MenuState> {
277279
menuShouldScrollIntoView,
278280
theme,
279281
} = this.props;
280-
const { getPortalPlacement } = this.context;
281282

282283
if (!ref) return;
283284

@@ -295,6 +296,7 @@ export class MenuPlacer extends Component<MenuPlacerProps, MenuState> {
295296
theme,
296297
});
297298

299+
const { getPortalPlacement } = this.context;
298300
if (getPortalPlacement) getPortalPlacement(state);
299301

300302
this.setState(state);
@@ -520,7 +522,9 @@ export class MenuPortal extends Component<MenuPortalProps, MenuPortalState> {
520522
);
521523

522524
return (
523-
<PortalPlacementContext.Provider value={this.getPortalPlacement}>
525+
<PortalPlacementContext.Provider
526+
value={{ getPortalPlacement: this.getPortalPlacement }}
527+
>
524528
{appendTo ? createPortal(menuWrapper, appendTo) : menuWrapper}
525529
</PortalPlacementContext.Provider>
526530
);

0 commit comments

Comments
 (0)