minor cleanups in Groups/ #2200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: 7ee5cb34-b2de-4686-ab68-ad54bbb918d7 -->
Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: a3aaa89e-2ebe-493d-9cb0-23c89a130d28 -->
Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: 0c8a6e24-89bd-490a-8ed3-cb6c06be623e -->
jdchristensen
approved these changes
Jan 19, 2025
Collaborator
jdchristensen
left a comment
There was a problem hiding this comment.
Feel free to merge with or without my suggested change.
| (** Pairs in direct products can be decomposed *) | ||
| Definition grp_prod_decompose {G H : Group} (g : G) (h : H) | ||
| : (g, h) = ((g, group_unit) : grp_prod G H) * (group_unit, h). | ||
| : (g, h) = ((g, 1) : grp_prod G H) * (1, h). |
Collaborator
There was a problem hiding this comment.
Does this work? If so, I think it's cleaner.
Suggested change
| : (g, h) = ((g, 1) : grp_prod G H) * (1, h). | |
| : (g, h) = (g, 1) * (1, h) :> grp_prod G H. |
Collaborator
Author
There was a problem hiding this comment.
It does not since it gets stuck looking for sgop of a prod. I had tried this before ideally we would have a pair "constructor" for groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.