Skip to content

Commit 5f2b392

Browse files
committed
Improve nobel-prize-simple example
1 parent fc1d6e6 commit 5f2b392

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/week3/7-oop/nobel-prize-simple/Model.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,13 @@
1919
}
2020

2121
async fetchData() {
22-
const newState = { ...this.state, error: null };
22+
this.state.error = null;
2323
try {
2424
const { laureates } = await Model.fetchJSON(API_URL);
25-
newState.laureates = laureates;
25+
this.state.laureates = laureates;
2626
} catch (err) {
27-
newState.error = err;
27+
this.state.error = err;
2828
}
29-
this.state = newState;
3029
this.notify(this.state);
3130
}
3231

src/week3/7-oop/nobel-prize-simple/View.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,13 @@
2727
id: 'list-container',
2828
});
2929
laureates.forEach(laureate => {
30+
const prizeYears = laureate.prizes
31+
.reduce((acc, prize) => acc.concat(prize.year), [])
32+
.join(', ');
3033
View.createAndAppend('li', ul, {
3134
class: 'list-item',
32-
text: `${laureate.firstname} ${laureate.surname || ''}`,
35+
text: `${laureate.firstname} ${laureate.surname ||
36+
''} (${prizeYears})`,
3337
});
3438
});
3539
}

0 commit comments

Comments
 (0)