Skip to content

Remove Develocity integration #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 3 commits into from
Nov 9, 2024
Merged

Remove Develocity integration #1014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daca585
Remove configureBuildScan
Goooler Nov 9, 2024
1260e12
Update README.md
Goooler Nov 9, 2024
cfa7970
Update README.md
Goooler Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/docs/changes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@

## [Unreleased]

**Removed**

- **BREAKING CHANGE:** Remove Develocity integration. ([#1013](https://github.com/GradleUp/shadow/pull/1013))


## [v8.3.5] (2024-11-03)

Expand Down
27 changes: 0 additions & 27 deletions src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,33 +25,6 @@ class ShadowPlugin implements Plugin<Project> {
// etc. if the user applies shadow before those plugins. However, this is fine, because this was also
// the behavior with the old plugin when applying in that order.
plugins.apply(LegacyShadowPlugin)

boolean enableDevelocityIntegration = providers.gradleProperty(
"com.gradleup.shadow.enableDevelocityIntegration"
).map { it.toBoolean() }.getOrElse(false)
if (enableDevelocityIntegration) {
// Legacy build scan support for Gradle Enterprise, users should migrate to develocity plugin.
rootProject.plugins.withId('com.gradle.enterprise') {
configureBuildScan(rootProject)
}
rootProject.plugins.withId('com.gradle.develocity') {
configureBuildScan(rootProject)
}
}
}
}

private void configureBuildScan(Project rootProject) {
rootProject.buildScan.buildFinished {
def shadowTasks = tasks.withType(ShadowJar)
shadowTasks.each { task ->
if (task.didWork) {
task.stats.buildScanData.each { k, v ->
rootProject.buildScan.value "shadow.${task.path}.${k}", v.toString()
}
rootProject.buildScan.value "shadow.${task.path}.configurations", task.configurations*.name.join(", ")
}
}
}
}
}