From dd1522cf48d8369613eb17764f62b6076b5e05f4 Mon Sep 17 00:00:00 2001 From: Katie McLaughlin Date: Wed, 13 Apr 2022 07:51:18 +1000 Subject: [PATCH 1/2] Fix type linting issuse (borrows from 7788) --- run/deployment-previews/test_app.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/run/deployment-previews/test_app.py b/run/deployment-previews/test_app.py index 47ce9816c63..093b78cbc87 100644 --- a/run/deployment-previews/test_app.py +++ b/run/deployment-previews/test_app.py @@ -13,7 +13,7 @@ # limitations under the License. import os -from typing import Any, List, NoReturn +from typing import Any, List, NoReturn, TypeVar from click.testing import CliRunner from mock import MagicMock, patch @@ -21,6 +21,8 @@ from check_status import cli +a = TypeVar("a") + MOCK_SERVICE_NAME = "myservice" MOCK_GH_TOKEN = "aaaaa" MOCK_REPO_NAME = "foocorp/bar" @@ -70,7 +72,7 @@ def service_data(name: str, tags: List[str]) -> dict: @patch("check_status.discovery") -def test_set_wrongtag(discovery_mock: Any) -> NoReturn: +def test_set_wrongtag(discovery_mock: a) -> NoReturn: service_mock = MagicMock() service_mock.projects = MagicMock(return_value=service_mock) service_mock.locations = MagicMock(return_value=service_mock) @@ -110,7 +112,7 @@ def test_set_wrongtag(discovery_mock: Any) -> NoReturn: @patch("check_status.discovery") @patch("check_status.github") -def test_set_check_calls(github_mock: Any, discovery_mock: Any) -> NoReturn: +def test_set_check_calls(github_mock: a, discovery_mock: a) -> NoReturn: service_mock = MagicMock() service_mock.projects = MagicMock(return_value=service_mock) service_mock.locations = MagicMock(return_value=service_mock) From 2f4bce746460aed4d3edd4f8fc36c28c32002288 Mon Sep 17 00:00:00 2001 From: Katie McLaughlin Date: Wed, 13 Apr 2022 07:58:36 +1000 Subject: [PATCH 2/2] Correct import --- run/deployment-previews/test_app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run/deployment-previews/test_app.py b/run/deployment-previews/test_app.py index 093b78cbc87..65618611992 100644 --- a/run/deployment-previews/test_app.py +++ b/run/deployment-previews/test_app.py @@ -13,7 +13,7 @@ # limitations under the License. import os -from typing import Any, List, NoReturn, TypeVar +from typing import List, NoReturn, TypeVar from click.testing import CliRunner from mock import MagicMock, patch