remove hardcoded permissions on cryptoKeyEncrypterDecrypter

[ScottSuarez]

This configuration will cause the permission to get deleted even if in use for other tests. Lets remove these hard coded permissions and then fix any failing tests by enabling them in pantheon UI on a per instance basis.

helps with hashicorp/terraform-provider-google#12908
Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1 insertion(+), 35 deletions(-))
Terraform Beta: Diff ( 2 files changed, 1 insertion(+), 35 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2471
Passed tests 2211
Skipped tests: 256
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPubsubTopic_cmek|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDnsRecordSet_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]

Tests failed during RECORDING mode:
TestAccPubsubTopic_cmek[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[ScottSuarez]

Note these tests are going to fail and thats expected until we update the values in Pantheon. If I change it now they will simply get unset by existing test runs. (if that makes sense)

[roaks3]

Yep, that makes sense.

LGTM. I also added a comment to b/268353203, since these permissions will have to be added to the other environments later.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 43 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 43 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 44 deletions(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 44 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2471
Passed tests 2214
Skipped tests: 256
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccApigeeAddonsConfig_apigeeAddonsTestExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]

All tests passed
View the build log or the debug log for each test