Restrict accelerator_topology_mode to beta

[jamOne-]

In #16641 I forgot to limit the feature to the beta provider.

compute: restrict `accelerator_topology_mode` field in `google_compute_resource_policy` resource  to beta

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[rileykarson]

Non-breaking: This was added yesterday and has not been released, so we can modify it freely.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 4 insertions(+), 74 deletions(-))
google-beta provider: Diff ( 3 files changed, 4 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 1 insertion(+), 35 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field workload_policy.accelerator_topology_mode within resource google_compute_resource_policy was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1382
Passed tests: 1291
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyAcceleratorTopologyModeExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeResourcePolicy_resourcePolicyWorkloadPolicyAcceleratorTopologyModeExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[jamOne-]

Fixed the test and verified it locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 5 insertions(+), 74 deletions(-))
google-beta provider: Diff ( 3 files changed, 6 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 1 insertion(+), 35 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field workload_policy.accelerator_topology_mode within resource google_compute_resource_policy was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1382
Passed tests: 1292
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[jamOne-]

@rileykarson PTAL again.

[jamOne-]

@rileykarson gentle ping. There's integration test failing, but I don't understand why as clicking on it navigates to a green run?

[rileykarson]

The run job itself is green but the test would have failed!

[rileykarson]

LGTM, thanks!

[rileykarson]

I can't see a related failure easily, assuming it's a flake in TGC

[jamOne-]

Ah got it, thank you