Add identityType, effectiveIdentity, and default_from_api to Vertex A… by mmontan · Pull Request #16638 · GoogleCloudPlatform/magic-modules

mmontan · 2026-03-07T17:43:37Z

Add identityType, effectiveIdentity, and default_from_api to google_vertex_ai_reasoning_engine (beta)

This PR adds two new beta fields to the spec block of google_vertex_ai_reasoning_engine:

identity_type (beta): Specifies the identity type to use for the Reasoning Engine. Accepts SERVICE_ACCOUNT (uses a custom service account if set, otherwise the default Vertex AI Reasoning Engine Service Agent) or AGENT_IDENTITY (uses Agent Identity; service_account must not be set).
effective_identity (beta, output-only): Reports the effective identity in use for the Reasoning Engine.

Additionally, default_from_api: true is added to the spec field to allow the API to populate defaults, as effective_identity is an output field computed server-side.

An acceptance test (TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate) is included to verify updating between SERVICE_ACCOUNT and AGENT_IDENTITY identity types using the beta provider.

Fixed hashicorp/terraform-provider-google#26376
Fixed hashicorp/terraform-provider-google#25101

Release Note Template for Downstream PRs (will be copied)

vertexai: added `spec.identity_type` and `spec.effective_identity` fields to `google_vertex_ai_reasoning_engine` resource (beta)

vertexai: marked `spec` field as computed in `google_vertex_ai_reasoning_engine` resource

…I ReasoningEngine

github-actions · 2026-03-07T17:44:00Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-03-07T17:55:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 77 insertions(+))
google-beta provider: Diff ( 4 files changed, 129 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-07T18:09:30Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-07T18:23:27Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineSourceUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

…random-string in names, and removed api_name fields.

modular-magician · 2026-03-12T02:52:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 81 insertions(+))
google-beta provider: Diff ( 4 files changed, 133 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-12T03:05:05Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-12T03:06:21Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

mmontan · 2026-03-12T13:52:09Z

Addressed the review comments and pushed updates. Ready for another look.

modular-magician · 2026-03-13T05:15:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 16 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 133 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-13T05:26:18Z

Tests analytics

Total tests: 85
Passed tests: 82
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

… failures

modular-magician · 2026-03-13T05:35:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 16 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 133 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-13T05:37:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 16 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 142 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-13T05:38:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 4 files changed, 142 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-13T05:44:40Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-13T05:46:56Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-13T05:47:48Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-13T06:06:01Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-03-13T06:06:08Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-03-13T06:09:32Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-03-13T23:09:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 4 files changed, 142 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-13T23:17:22Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-13T23:17:39Z

🔴 Tests failed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-03-13T23:18:01Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-13T23:18:17Z

🔴 Tests failed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-03-13T23:18:54Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-13T23:18:55Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-13T23:19:09Z

🔴 Tests failed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-03-13T23:19:11Z

🔴 Tests failed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-03-13T23:19:13Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-13T23:19:28Z

🔴 Tests failed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-03-14T16:09:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 4 files changed, 142 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-14T16:18:49Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-14T16:39:04Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

…terministic in the update of the policy

modular-magician · 2026-03-14T23:03:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 27 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 4 files changed, 144 insertions(+), 9 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

modular-magician · 2026-03-14T23:13:10Z

Tests analytics

Total tests: 85
Passed tests: 81
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-03-14T23:32:48Z

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

zli82016

LGTM. Thanks.

GoogleCloudPlatform#16638) Co-authored-by: Zhenhua Li <zhenhuali@google.com>

Add identityType, effectiveIdentity, and default_from_api to Vertex A…

6892814

…I ReasoningEngine

github-actions Bot requested a review from zli82016 March 7, 2026 17:43

modular-magician added the service/aiplatform-agent-engine label Mar 7, 2026

zli82016 requested changes Mar 10, 2026

View reviewed changes

Addressed comments in the review, adding context in the tests to add …

47fb779

…random-string in names, and removed api_name fields.

github-actions Bot requested a review from zli82016 March 12, 2026 02:40

zli82016 requested changes Mar 12, 2026

View reviewed changes

Comment thread mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_reasoning_engine_test.go.tmpl

Added a version guard to the test for beta resource.

ed16bf5

github-actions Bot requested a review from zli82016 March 13, 2026 05:04

mmontan force-pushed the vertex-ai-reasoning-engine-identity branch from f98809a to ed16bf5 Compare March 13, 2026 05:26

Added random suffix to addtional tests to remove more sources of test…

c104b06

… failures

Shortened name of service account to be < 30 characters

b51f710

Changed tests to add a dependency between IAM updates to avoid non-de…

20caf9f

…terministic in the update of the policy

zli82016 approved these changes Mar 16, 2026

View reviewed changes

zli82016 added this pull request to the merge queue Mar 16, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 3b5fb17 Mar 16, 2026
23 checks passed

zli82016 added a commit to trodge/magic-modules that referenced this pull request Mar 16, 2026

Add identityType, effectiveIdentity, and default_from_api to Vertex A… (

e2a3e8a

GoogleCloudPlatform#16638) Co-authored-by: Zhenhua Li <zhenhuali@google.com>

aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 18, 2026

Add identityType, effectiveIdentity, and default_from_api to Vertex A… (

f4ab405

GoogleCloudPlatform#16638) Co-authored-by: Zhenhua Li <zhenhuali@google.com>

ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026

Add identityType, effectiveIdentity, and default_from_api to Vertex A… (

830f54f

GoogleCloudPlatform#16638) Co-authored-by: Zhenhua Li <zhenhuali@google.com>

gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026

Add identityType, effectiveIdentity, and default_from_api to Vertex A… (

4b134b5

GoogleCloudPlatform#16638) Co-authored-by: Zhenhua Li <zhenhuali@google.com>

Conversation

mmontan commented Mar 7, 2026 • edited by zli82016 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 7, 2026

Uh oh!

modular-magician commented Mar 7, 2026

Diff report

Uh oh!

modular-magician commented Mar 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Mar 12, 2026

Diff report

Uh oh!

modular-magician commented Mar 12, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 12, 2026

Uh oh!

mmontan commented Mar 12, 2026

Uh oh!

Uh oh!

modular-magician commented Mar 13, 2026

Diff report

Uh oh!

modular-magician commented Mar 13, 2026

Tests analytics

Uh oh!

modular-magician commented Mar 13, 2026

Diff report

Uh oh!

modular-magician commented Mar 13, 2026

Diff report

Uh oh!

modular-magician commented Mar 13, 2026

Diff report

Uh oh!

modular-magician commented Mar 13, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 13, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 13, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 13, 2026

Uh oh!

modular-magician commented Mar 13, 2026

Uh oh!

modular-magician commented Mar 13, 2026

Uh oh!

modular-magician commented Mar 13, 2026

Diff report

Uh oh!

modular-magician commented Mar 13, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 13, 2026

Uh oh!

modular-magician commented Mar 13, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 13, 2026

Uh oh!

mmontan commented Mar 7, 2026 •

edited by zli82016

Loading