Skip to content

fix caching in magic-modules#16594

Merged
ScottSuarez merged 5 commits into
GoogleCloudPlatform:mainfrom
ScottSuarez:fix-cache
Mar 4, 2026
Merged

fix caching in magic-modules#16594
ScottSuarez merged 5 commits into
GoogleCloudPlatform:mainfrom
ScottSuarez:fix-cache

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

2 similar comments
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez
Copy link
Copy Markdown
Contributor Author

@modular-magician assign-review @melinath

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from melinath March 3, 2026 21:07
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that it's built-in to setup-go now!

Comment thread .github/workflows/unit-test-tgc.yml
Comment thread .github/workflows/unit-test-tpg.yml
uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
with:
go-version: '^1.24'
# Disable caching for now due to issues with large provider dependency caches
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to double-check, has something changed such that the large cache size is no longer an issue? or are we just going for it & hoping.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez added this pull request to the merge queue Mar 4, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 58b456f Mar 4, 2026
26 checks passed
@ScottSuarez ScottSuarez deleted the fix-cache branch March 4, 2026 18:43
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants