Skip to content

tgc-revival: add Compute resources #16593

Merged
zli82016 merged 4 commits into
GoogleCloudPlatform:mainfrom
zli82016:refactor-compute-part-2
Mar 6, 2026
Merged

tgc-revival: add Compute resources #16593
zli82016 merged 4 commits into
GoogleCloudPlatform:mainfrom
zli82016:refactor-compute-part-2

Conversation

@zli82016
Copy link
Copy Markdown
Member

@zli82016 zli82016 commented Mar 3, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@zli82016 zli82016 force-pushed the refactor-compute-part-2 branch from d6e0c73 to 919352b Compare March 3, 2026 20:13
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 29 files changed, 5663 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 84 files changed, 531 deletions(-))
google-beta provider: Diff ( 86 files changed, 543 deletions(-))
terraform-google-conversion: Diff ( 29 files changed, 5663 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_autoscaler (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      single_instance_assignment = # value needed
    }
  }
}

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  backend {
    max_rate = # value needed
  }
  cdn_policy {
    cache_key_policy {
      query_string_blacklist = # value needed
    }
  }
}

Resource: google_compute_forwarding_rule (120 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_forwarding_rule" "primary" {
  service_label = # value needed
}

Resource: google_compute_ha_vpn_gateway (39 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ha_vpn_gateway" "primary" {
  vpn_interfaces {
    interconnect_attachment = # value needed
  }
}

Resource: google_compute_region_autoscaler (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      name                       = # value needed
      single_instance_assignment = # value needed
      target                     = # value needed
    }
  }
}

Resource: google_compute_region_backend_service (231 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  affinity_cookie_ttl_sec = # value needed
  backend {
    max_connections              = # value needed
    max_connections_per_endpoint = # value needed
    max_connections_per_instance = # value needed
  }
  cdn_policy {
    cache_key_policy {
      include_query_string   = # value needed
      query_string_blacklist = # value needed
      query_string_whitelist = # value needed
    }
  }
}

Resource: google_compute_region_network_endpoint_group (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_endpoint_group" "primary" {
  app_engine {
    url_mask = # value needed
  }
  cloud_function {
    url_mask = # value needed
  }
  cloud_run {
    url_mask = # value needed
  }
}

Resource: google_compute_region_network_firewall_policy_rule (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
}

Resource: google_compute_region_url_map (76 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  default_url_redirect {
    redirect_response_code = # value needed
  }
  path_matcher {
    default_route_action {
      url_rewrite {
        path_template_rewrite = # value needed
      }
    }
    default_url_redirect {
      redirect_response_code = # value needed
    }
    path_rule {
      url_redirect {
        redirect_response_code = # value needed
      }
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

Resource: google_compute_router_nat (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_nat" "primary" {
  rules {
    match = # value needed
  }
}

Resource: google_compute_url_map (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    default_url_redirect {
      redirect_response_code = # value needed
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 84 files changed, 531 deletions(-))
google-beta provider: Diff ( 86 files changed, 543 deletions(-))
terraform-google-conversion: Diff ( 29 files changed, 5663 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_autoscaler (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      single_instance_assignment = # value needed
    }
  }
}

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  backend {
    max_rate = # value needed
  }
  cdn_policy {
    cache_key_policy {
      query_string_blacklist = # value needed
    }
  }
}

Resource: google_compute_forwarding_rule (120 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_forwarding_rule" "primary" {
  service_label = # value needed
}

Resource: google_compute_ha_vpn_gateway (39 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ha_vpn_gateway" "primary" {
  vpn_interfaces {
    interconnect_attachment = # value needed
  }
}

Resource: google_compute_region_autoscaler (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      name                       = # value needed
      single_instance_assignment = # value needed
      target                     = # value needed
    }
  }
}

Resource: google_compute_region_backend_service (231 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  affinity_cookie_ttl_sec = # value needed
  backend {
    max_connections              = # value needed
    max_connections_per_endpoint = # value needed
    max_connections_per_instance = # value needed
  }
  cdn_policy {
    cache_key_policy {
      include_query_string   = # value needed
      query_string_blacklist = # value needed
      query_string_whitelist = # value needed
    }
  }
}

Resource: google_compute_region_network_endpoint_group (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_endpoint_group" "primary" {
  app_engine {
    url_mask = # value needed
  }
  cloud_function {
    url_mask = # value needed
  }
  cloud_run {
    url_mask = # value needed
  }
}

Resource: google_compute_region_network_firewall_policy_rule (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
}

Resource: google_compute_region_url_map (76 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  default_url_redirect {
    redirect_response_code = # value needed
  }
  path_matcher {
    default_route_action {
      url_rewrite {
        path_template_rewrite = # value needed
      }
    }
    default_url_redirect {
      redirect_response_code = # value needed
    }
    path_rule {
      url_redirect {
        redirect_response_code = # value needed
      }
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

Resource: google_compute_router_nat (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_nat" "primary" {
  rules {
    match = # value needed
  }
}

Resource: google_compute_url_map (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    default_url_redirect {
      redirect_response_code = # value needed
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

@zli82016
Copy link
Copy Markdown
Member Author

zli82016 commented Mar 3, 2026

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 29 files changed, 5663 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 29 files changed, 5663 insertions(+), 4 deletions(-))

@zli82016 zli82016 changed the title Refactor include_in_tgc_next in Compute resources (Part 2) tgc-revival: add Compute resources Mar 5, 2026
@zli82016 zli82016 marked this pull request as ready for review March 6, 2026 17:36
@zli82016 zli82016 requested a review from hao-nan-li March 6, 2026 17:37
@zli82016 zli82016 added this pull request to the merge queue Mar 6, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 8f75459 Mar 6, 2026
26 checks passed
@zli82016 zli82016 deleted the refactor-compute-part-2 branch March 6, 2026 18:04
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants