Skip to content

Add scopes to service account auth in CES Toolsets#16580

Merged
roaks3 merged 1 commit into
GoogleCloudPlatform:mainfrom
habh-11:ces-service-account-scopes
Mar 6, 2026
Merged

Add scopes to service account auth in CES Toolsets#16580
roaks3 merged 1 commit into
GoogleCloudPlatform:mainfrom
habh-11:ces-service-account-scopes

Conversation

@habh-11
Copy link
Copy Markdown
Contributor

@habh-11 habh-11 commented Mar 2, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

ces: added Service Account OAuth `scopes` fields to `google_ces_toolset` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 2, 2026
@github-actions github-actions Bot requested a review from roaks3 March 2, 2026 19:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Copy Markdown
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@modular-magician modular-magician added service/ces and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 6, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 94 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 5 files changed, 94 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 50
Passed tests: 46
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • ces

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCESToolset_cesToolsetMcpServiceAccountAuthConfigExample
  • TestAccCESToolset_cesToolsetMcpServiceAccountAuthConfigExample_update
  • TestAccCESToolset_cesToolsetOpenapiServiceAccountAuthConfigExample
  • TestAccCESToolset_cesToolsetOpenapiServiceAccountAuthConfigExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCESToolset_cesToolsetMcpServiceAccountAuthConfigExample [Debug log]
TestAccCESToolset_cesToolsetMcpServiceAccountAuthConfigExample_update [Debug log]
TestAccCESToolset_cesToolsetOpenapiServiceAccountAuthConfigExample [Debug log]
TestAccCESToolset_cesToolsetOpenapiServiceAccountAuthConfigExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@habh-11 habh-11 closed this Mar 6, 2026
@habh-11 habh-11 reopened this Mar 6, 2026
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 6, 2026
@github-actions github-actions Bot requested a review from roaks3 March 6, 2026 01:29
@habh-11
Copy link
Copy Markdown
Contributor Author

habh-11 commented Mar 6, 2026

@roaks3 Can you merge this, or anything I need to do to merge it? (I don't see the option for it)

@roaks3
Copy link
Copy Markdown
Contributor

roaks3 commented Mar 6, 2026

Only our team can merge, so you can just leave it and I will do that. Looks like we'll need to run tests again.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 6, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 94 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 5 files changed, 94 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 50
Passed tests: 50
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • ces

🟢 All tests passed!

View the build log

Copy link
Copy Markdown
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TGC failure looks like a flake

@roaks3 roaks3 added this pull request to the merge queue Mar 6, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 8e2d568 Mar 6, 2026
50 of 51 checks passed
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants