add logic to short circuit updates in deletion policy generation

[NickElliot]

I should've caught this earlier, hopefully this PR won't be too fussy with the number of diffs

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 271 files changed, 5021 insertions(+), 1759 deletions(-))
google-beta provider: Diff ( 295 files changed, 5547 insertions(+), 1981 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• accesscontextmanager
• appengine
• bigquerydatapolicyv2
• bigtable
• binaryauthorization
• cloudsecuritycompliance
• cloudtasks
• corebilling
• artifactregistry
• bigqueryconnection
• datacatalog
• dataproc
• developerconnect
• eventarc
• firebaseappcheck
• apigateway
• contactcenterinsights
• essentialcontacts
• firebaseailogic
• biglakeiceberg
• cloudrun
• datapipeline
• deploymentmanager
• edgecontainer
• accessapproval
• apigee
• apphub
• composer
• compute
• dataprocgdc
• firestore
• blockchainnodeengine
• firebaseextensions
• activedirectory
• bigquery
• bigquerydatapolicy
• bigquerydatatransfer
• cloudfunctions2
• apihub
• billing
• ces
• dataform
• datalossprevention
• beyondcorp
• cloudasset
• cloudbuildv2
• firebasehosting
• bigqueryanalyticshub
• cloudids
• datafusion
• chronicle
• cloudidentity
• dialogflowcx
• discoveryengine
• alloydb
• bigqueryreservation
• cloudbuild
• cloudscheduler
• filestore
• certificatemanager
• colab
• dataplex
• biglake
• cloudrunv2
• firebaseapphosting
• firebasedatabase
• backupdr
• databasemigrationservice
• clouddeploy
• containeranalysis
• datastream
• dialogflow
• dns

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 571 files changed, 3551 insertions(+))
google-beta provider: Diff ( 626 files changed, 3870 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5100
Passed tests: 4623
Skipped tests: 438
Affected tests: 39

Click here to see the affected service packages

• datastream
• gkebackup
• pubsub
• serviceusage
• bigquerydatatransfer
• chronicle
• dataprocgdc
• dialogflowcx
• iam2
• iam3
• securityposture
• workstations
• cloudtasks
• gkehub
• modelarmor
• privilegedaccessmanager
• apigateway
• cloudfunctions2
• discoveryengine
• migrationcenter
• tpuv2
• vpcaccess
• oslogin
• biglakeiceberg
• observability
• workflows
• filestore
• firebasehosting
• osconfigv2
• sql
• vmwareengine
• blockchainnodeengine
• cloudidentity
• firebaseappcheck
• iamworkforcepool
• bigqueryreservation
• cloudbuildv2
• datalossprevention
• identityplatform
• networkservices
• securitycenter
• securityscanner
• storagecontrol
• edgecontainer
• essentialcontacts
• accessapproval
• backupdr
• firebase
• iambeta
• logging
• modelarmorglobal
• orgpolicy
• storageinsights
• integrationconnectors
• netapp
• workbench
• firebasedatabase
• gkeonprem
• bigqueryanalyticshub
• securitycentermanagement
• appengine
• dialogflow
• networksecurity
• redis
• resourcemanager3
• securesourcemanager
• cloudrun
• colab
• monitoring
• servicedirectory
• sourcerepo
• apihub
• containeranalysis
• containerattached
• firebaseextensions
• lustre
• storage
• firebaseailogic
• firebasedataconnect
• secretmanagerregional
• tags
• activedirectory
• artifactregistry
• cloudscheduler
• integrations
• bigquerydatapolicy
• cloudbuild
• cloudsecuritycompliance
• privateca
• beyondcorp
• bigquery
• bigqueryconnection
• certificatemanager
• deploymentmanager
• eventarc
• firestore
• memcache
• cloudasset
• cloudquotas
• databasemigrationservice
• healthcare
• networkconnectivityv1
• notebooks
• parallelstore
• saasruntime
• ces
• dataproc
• gkehub2
• networkconnectivity
• apphub
• binaryauthorization
• cloudrunv2
• developerconnect
• memorystore
• secretmanager
• accesscontextmanager
• composer
• datacatalog
• datapipeline
• firebaseapphosting
• networkmanagement
• storagetransfer
• apigee
• iap
• osconfig
• parametermanagerregional
• securitycenterv2
• vertexai
• biglake
• bigquerydatapolicyv2
• servicenetworking
• storagebatchoperations
• dns
• managedkafka
• parametermanager
• corebilling
• dataform
• dataprocmetastore
• gemini
• spanner
• bigtable
• contactcenterinsights
• kms
• datafusion
• dataplex
• billing
• looker
• pubsublite
• alloydb
• clouddeploy
• cloudids
• compute

Action taken

Found 39 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager
• TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
• TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated
• TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition
• TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated
• TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition
• TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated
• TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition
• TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample
• TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update
• TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationSpaApiExample
• TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationSpaProxyExample
• TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample
• TestAccBeyondcorpSecurityGatewayIamBindingGenerated
• TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition
• TestAccBeyondcorpSecurityGatewayIamMemberGenerated
• TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition
• TestAccBeyondcorpSecurityGatewayIamPolicyGenerated
• TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition
• TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample
• TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_update
• TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewaySpaExample
• TestAccBigqueryAnalyticsHubListingSubscription_bigqueryAnalyticshubListingSubscriptionBasicExample
• TestAccBigqueryAnalyticsHubListingSubscription_differentProject
• TestAccCESAgent_cesAgentBasicExample_update
• TestAccCESAgent_cesAgentRemoteDialogflowAgentExample_update
• TestAccCESApp_cesAppBasicExample
• TestAccCloudRunService_cloudRunServiceIapExample
• TestAccCloudRunService_cloudRunServiceIap_update
• TestAccCloudRunV2Service_cloudrunv2ServiceIapExample
• TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate
• TestAccComposerEnvironmentComposer2_private
• TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
• TestAccDataLossPreventionDiscoveryConfig_Update
• TestAccDataSourceGoogleBeyondcorpSecurityGateway_basic
• TestAccDataSourceGoogleBeyondcorpSecurityGateway_full
• TestAccDeveloperConnectConnection_GhePrivConnection
• TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update
• TestAccModelArmorGlobalFloorsetting_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationSpaApiExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationSpaProxyExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample [Debug log]
TestAccBeyondcorpSecurityGatewayIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample [Debug log]
TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_update [Debug log]
TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewaySpaExample [Debug log]
TestAccBigqueryAnalyticsHubListingSubscription_bigqueryAnalyticshubListingSubscriptionBasicExample [Debug log]
TestAccBigqueryAnalyticsHubListingSubscription_differentProject [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__actions [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__aws_s3 [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__aws_single [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__basic [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__bq_single [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__cloud_sql [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__conditions [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__filter [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__gcs [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__gcs_single [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__org [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__secrets [Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update__sql_single [Debug log]
TestAccDataSourceGoogleBeyondcorpSecurityGateway_basic [Debug log]
TestAccDataSourceGoogleBeyondcorpSecurityGateway_full [Debug log]
TestAccModelArmorGlobalFloorsetting_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccCESAgent_cesAgentBasicExample_update [Error message] [Debug log]
TestAccCESAgent_cesAgentRemoteDialogflowAgentExample_update [Error message] [Debug log]
TestAccCESApp_cesAppBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceIapExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceIap_update [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate [Error message] [Debug log]
TestAccComposerEnvironmentComposer2_private [Error message] [Debug log]
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty [Error message] [Debug log]
TestAccDeveloperConnectConnection_GhePrivConnection [Error message] [Debug log]
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[c2thorn]

Requests/questions above, also do you have a quick log of the short circuit

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 571 files changed, 3822 insertions(+))
google-beta provider: Diff ( 626 files changed, 4165 insertions(+))

[modular-magician]

Tests analytics

Total tests: 5101
Passed tests: 4641
Skipped tests: 438
Affected tests: 22

Click here to see the affected service packages

• bigqueryreservation
• deploymentmanager
• gkehub
• vertexai
• biglake
• biglakeiceberg
• chronicle
• iap
• servicenetworking
• kms
• lustre
• essentialcontacts
• firebaseappcheck
• gemini
• storageinsights
• workbench
• apigee
• cloudids
• firebaseextensions
• saasruntime
• cloudrun
• corebilling
• migrationcenter
• clouddeploy
• firebaseailogic
• pubsublite
• securityscanner
• ces
• cloudasset
• datacatalog
• dataprocgdc
• healthcare
• parametermanager
• storagetransfer
• vmwareengine
• binaryauthorization
• dataproc
• gkeonprem
• privilegedaccessmanager
• securesourcemanager
• serviceusage
• accesscontextmanager
• compute
• containeranalysis
• iambeta
• modelarmorglobal
• osconfigv2
• servicedirectory
• storage
• alloydb
• cloudbuildv2
• datalossprevention
• sql
• tags
• monitoring
• networkconnectivity
• networkservices
• appengine
• artifactregistry
• firestore
• iamworkforcepool
• osconfig
• notebooks
• apphub
• bigqueryanalyticshub
• certificatemanager
• cloudsecuritycompliance
• eventarc
• iam2
• securityposture
• spanner
• workstations
• blockchainnodeengine
• dataform
• iam3
• redis
• resourcemanager3
• cloudrunv2
• cloudscheduler
• developerconnect
• dialogflowcx
• firebasehosting
• secretmanagerregional
• cloudbuild
• cloudquotas
• firebase
• firebaseapphosting
• bigquery
• bigtable
• cloudtasks
• colab
• storagebatchoperations
• storagecontrol
• datastream
• netapp
• networkconnectivityv1
• orgpolicy
• parallelstore
• parametermanagerregional
• securitycenter
• modelarmor
• tpuv2
• databasemigrationservice
• firebasedatabase
• activedirectory
• containerattached
• datapipeline
• filestore
• gkehub2
• logging
• oslogin
• vpcaccess
• backupdr
• dialogflow
• gkebackup
• securitycenterv2
• dataprocmetastore
• identityplatform
• memorystore
• pubsub
• securitycentermanagement
• apihub
• bigquerydatatransfer
• integrations
• managedkafka
• sourcerepo
• looker
• beyondcorp
• bigquerydatapolicy
• billing
• datafusion
• dataplex
• dns
• firebasedataconnect
• discoveryengine
• integrationconnectors
• memcache
• secretmanager
• networksecurity
• apigateway
• cloudfunctions2
• composer
• observability
• bigquerydatapolicyv2
• contactcenterinsights
• privateca
• bigqueryconnection
• cloudidentity
• edgecontainer
• networkmanagement
• workflows
• accessapproval

Action taken

Found 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager
• TestAccCESAgent_cesAgentBasicExample
• TestAccCESAgent_cesAgentBasicExample_update
• TestAccCESAgent_cesAgentRemoteDialogflowAgentExample_update
• TestAccCESApp_cesAppBasicExample
• TestAccCloudRunService_cloudRunServiceIapExample
• TestAccCloudRunService_cloudRunServiceIap_update
• TestAccCloudRunV2Service_cloudrunv2ServiceIapExample
• TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate
• TestAccComposerEnvironmentComposer2_private
• TestAccComputeInstance_bootDiskUpdate
• TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleBasicExample
• TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
• TestAccDataSourceGoogleStorageControlFolderIntelligenceConfig_basic
• TestAccDataSourceGoogleStorageControlOrganizationIntelligenceConfig_basic
• TestAccDataSourceGoogleStorageControlProjectIntelligenceConfig_basic
• TestAccDeveloperConnectConnection_GhePrivConnection
• TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update
• TestAccSqlDatabaseInstance_settings_secondary
• TestAccStorageControlFolderIntelligenceConfig_update
• TestAccStorageControlOrganizationIntelligenceConfig_update
• TestAccStorageControlProjectIntelligenceConfig_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccComputeInstance_bootDiskUpdate [Debug log]
TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleBasicExample [Debug log]
TestAccDataSourceGoogleStorageControlFolderIntelligenceConfig_basic [Debug log]
TestAccDataSourceGoogleStorageControlOrganizationIntelligenceConfig_basic [Debug log]
TestAccDataSourceGoogleStorageControlProjectIntelligenceConfig_basic [Debug log]
TestAccSqlDatabaseInstance_settings_secondary [Debug log]
TestAccStorageControlFolderIntelligenceConfig_update [Debug log]
TestAccStorageControlOrganizationIntelligenceConfig_update [Debug log]
TestAccStorageControlProjectIntelligenceConfig_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccCESAgent_cesAgentBasicExample [Error message] [Debug log]
TestAccCESAgent_cesAgentBasicExample_update [Error message] [Debug log]
TestAccCESAgent_cesAgentRemoteDialogflowAgentExample_update [Error message] [Debug log]
TestAccCESApp_cesAppBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceIapExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceIap_update [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapExample [Error message] [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceIapUpdate [Error message] [Debug log]
TestAccComposerEnvironmentComposer2_private [Error message] [Debug log]
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty [Error message] [Debug log]
TestAccDeveloperConnectConnection_GhePrivConnection [Error message] [Debug log]
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[NickElliot]

short circuit success
gpaste/6433825359003648

short circuit avoided when altering a nested object
gpaste/5896358218301440

[c2thorn]

thanks for the logs, confirmed it is short circuiting and logging when its supposed to