Skip to content

tgc-revival: apply DiffSuppressFunc in testing framework#16284

Merged
zli82016 merged 3 commits into
GoogleCloudPlatform:mainfrom
zli82016:tgc-diffsuppress-refactor
Mar 13, 2026
Merged

tgc-revival: apply DiffSuppressFunc in testing framework#16284
zli82016 merged 3 commits into
GoogleCloudPlatform:mainfrom
zli82016:tgc-diffsuppress-refactor

Conversation

@zli82016
Copy link
Copy Markdown
Member

@zli82016 zli82016 commented Feb 3, 2026

Sometimes the missing fields can be ignored by calling the DiffSuppressFunc. Apply DiffSuppressFunc during in the testing framework to check if the missing fields are really missing or not.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 312 insertions(+), 34 deletions(-))

@zli82016 zli82016 force-pushed the tgc-diffsuppress-refactor branch 3 times, most recently from dc88938 to 8f03b10 Compare March 13, 2026 17:51
@zli82016 zli82016 changed the title test tgc-revival: apply DiffSuppressFunc in testing framework Mar 13, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 308 insertions(+), 32 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 310 insertions(+), 32 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 310 insertions(+), 32 deletions(-))

@zli82016 zli82016 force-pushed the tgc-diffsuppress-refactor branch from 8f03b10 to c14ddc6 Compare March 13, 2026 18:07
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 8 files changed, 319 insertions(+), 42 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 8 files changed, 319 insertions(+), 42 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 9 files changed, 323 insertions(+), 58 deletions(-))

@zli82016 zli82016 force-pushed the tgc-diffsuppress-refactor branch from 8aab08b to 695bbcb Compare March 13, 2026 19:13
@zli82016 zli82016 force-pushed the tgc-diffsuppress-refactor branch from 695bbcb to 1ccda3c Compare March 13, 2026 19:15
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 9 files changed, 323 insertions(+), 58 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 9 files changed, 323 insertions(+), 58 deletions(-))

@zli82016
Copy link
Copy Markdown
Member Author

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 9 files changed, 323 insertions(+), 58 deletions(-))

@zli82016 zli82016 marked this pull request as ready for review March 13, 2026 20:34
@zli82016 zli82016 force-pushed the tgc-diffsuppress-refactor branch from 1e0cc5f to 1ccda3c Compare March 13, 2026 20:36
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 9 files changed, 323 insertions(+), 58 deletions(-))

@zli82016 zli82016 requested a review from trodge March 13, 2026 21:21
@zli82016 zli82016 added this pull request to the merge queue Mar 13, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 0e90cb4 Mar 13, 2026
39 of 41 checks passed
@zli82016 zli82016 deleted the tgc-diffsuppress-refactor branch March 13, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants