Reject boolean counts in V1 analytics payload

Author: cursoragent

api/app_analytics/serializers.py

@@ -137,7 +137,7 @@ def to_internal_value(self, data: Any) -> dict[str, int]:
         return {
             name: count
             for name, count in data.items()
-            if isinstance(name, str) and isinstance(count, int)
+            if isinstance(name, str) and type(count) is int
         }
 
     def validate(self, attrs: dict[str, int]) -> dict[str, int]:

api/tests/unit/app_analytics/test_unit_app_analytics_views.py

@@ -110,6 +110,31 @@ def test_sdk_analytics_ignores_bad_data(
     )
 
 
+def test_sdk_analytics_flags_v1__boolean_count__is_skipped(
+    mocker: MockerFixture,
+    environment: Environment,
+    feature: Feature,
+    api_client: APIClient,
+) -> None:
+    # Given
+    api_client.credentials(HTTP_X_ENVIRONMENT_KEY=environment.api_key)
+    data = {feature.name: True}
+    mocked_feature_eval_cache = mocker.patch(
+        "app_analytics.views.feature_evaluation_cache"
+    )
+
+    url = reverse("api-v1:analytics-flags")
+
+    # When
+    response = api_client.post(
+        url, data=json.dumps(data), content_type="application/json"
+    )
+
+    # Then
+    assert response.status_code == status.HTTP_200_OK
+    mocked_feature_eval_cache.track_feature_evaluation.assert_not_called()
+
+
 def test_get_usage_data(mocker, admin_client, organisation):  # type: ignore[no-untyped-def]
     # Given
     url = reverse("api-v1:organisations:usage-data", args=[organisation.id])