Conversation
khvn26
commented
Aug 18, 2025
matthewelwell
previously approved these changes
Aug 19, 2025
Contributor
matthewelwell
left a comment
There was a problem hiding this comment.
Looks good to me notwithstanding the CI failure which seems like a 'simple' dependency mismatch.
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against bfe1065 |
Zaimwa9
reviewed
Aug 19, 2025
88acfac to
3ab4520
Compare
CodSpeed Performance ReportMerging #243 will degrade performances by 15.35%Comparing Summary
Benchmarks breakdown
|
matthewelwell
approved these changes
Aug 20, 2025
Zaimwa9
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #233.
This adds JSONPath support based on
jsonpath_rfc9535library.Context value getters are now implemented with cached JSONPath resolvers.
All segment condition properties not compiling to a JSONPath query are assumed to be trait keys.
In case multiple values match the query, the engine picks the first one.
A runtime type check is added to avoid comparing against anything but scalar values.