Skip to content

Commit f17476f

Browse files
authored
Merge pull request #1568 from lnxtree/feat-fix-embedder_use_bf16
fix(eval): pass use_bf16 through AbsEvalRunner.get_model and COIR evaluator model initialization
2 parents 4bcfc6e + 7e53f57 commit f17476f

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

  • FlagEmbedding/abc/evaluation
  • research/BGE_Coder/evaluation/coir_eval

FlagEmbedding/abc/evaluation/runner.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ def get_models(model_args: AbsEvalModelArgs) -> Tuple[AbsEmbedder, Union[AbsRera
5050
normalize_embeddings=model_args.normalize_embeddings,
5151
pooling_method=model_args.pooling_method,
5252
use_fp16=model_args.use_fp16,
53+
use_bf16=model_args.use_bf16,
5354
query_instruction_for_retrieval=model_args.query_instruction_for_retrieval,
5455
query_instruction_format=model_args.query_instruction_format_for_retrieval,
5556
devices=model_args.devices,

research/BGE_Coder/evaluation/coir_eval/main.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ def get_model(model_args: COIREvalModelArgs):
1717
normalize_embeddings=model_args.normalize_embeddings,
1818
pooling_method=model_args.pooling_method,
1919
use_fp16=model_args.use_fp16,
20+
use_bf16=model_args.use_bf16,
2021
query_instruction_for_retrieval=model_args.query_instruction_for_retrieval,
2122
query_instruction_format=model_args.query_instruction_format_for_retrieval,
2223
devices=model_args.devices,
@@ -32,6 +33,7 @@ def get_model(model_args: COIREvalModelArgs):
3233
normalize_embeddings=model_args.normalize_embeddings,
3334
pooling_method=model_args.pooling_method,
3435
use_fp16=model_args.use_fp16,
36+
use_bf16=model_args.use_bf16,
3537
query_instruction_for_retrieval=model_args.query_instruction_for_retrieval,
3638
query_instruction_format=model_args.query_instruction_format_for_retrieval,
3739
devices=model_args.devices,

0 commit comments

Comments
 (0)