Skip to content

Fix Plaid personal card showing generic art on details page #89217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amyevans merged 3 commits into from
May 18, 2026
Merged

Fix Plaid personal card showing generic art on details page #89217

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
689f6a0
Fix Plaid personal card showing generic art on details page
MelvinBot Apr 29, 2026
db84e14
Merge remote-tracking branch 'origin/main' into claude-fixPlaidPerson…
MelvinBot May 17, 2026
a514473
Move plaidUrl below NotFoundPage early returns
MelvinBot May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/pages/settings/Wallet/PersonalCardDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import HeaderWithBackButton from '@components/HeaderWithBackButton';
import ImageSVG from '@components/ImageSVG';
import {ModalActions} from '@components/Modal/Global/ModalContext';
import OfflineWithFeedback from '@components/OfflineWithFeedback';
import PlaidCardFeedIcon from '@components/PlaidCardFeedIcon';
import ScreenWrapper from '@components/ScreenWrapper';
import ScrollView from '@components/ScrollView';
import {useCompanyCardFeedIcons} from '@hooks/useCompanyCardIcons';
Expand All @@ -18,7 +19,7 @@ import useOnyx from '@hooks/useOnyx';
import useThemeIllustrations from '@hooks/useThemeIllustrations';
import useThemeStyles from '@hooks/useThemeStyles';
import {isUsingStagingApi} from '@libs/ApiUtils';
import {getCardFeedIcon, isCardConnectionBroken, isPersonalCard} from '@libs/CardUtils';
import {getCardFeedIcon, getPlaidInstitutionIconUrl, isCardConnectionBroken, isPersonalCard} from '@libs/CardUtils';
import {getLatestErrorField} from '@libs/ErrorUtils';
import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
import type {SettingsNavigatorParamList} from '@libs/Navigation/types';
Expand Down Expand Up @@ -142,6 +143,8 @@ function PersonalCardDetailsPage({route}: PersonalCardDetailsPageProps) {
return <NotFoundPage />;
}

const plaidUrl = getPlaidInstitutionIconUrl(cardBank as CompanyCardFeed);

return (
<ScreenWrapper
enableEdgeToEdgeBottomSafeAreaPadding
Expand All @@ -153,13 +156,20 @@ function PersonalCardDetailsPage({route}: PersonalCardDetailsPageProps) {
/>
<ScrollView addBottomSafeAreaPadding>
<View style={[styles.walletCard, styles.mb3]}>
<ImageSVG
contentFit="contain"
src={getCardIconSource()}
pointerEvents="none"
height={variables.cardPreviewHeight}
width={variables.cardPreviewWidth}
/>
{plaidUrl ? (
<PlaidCardFeedIcon
plaidUrl={plaidUrl}
isLarge
/>
) : (
<ImageSVG
contentFit="contain"
src={getCardIconSource()}
pointerEvents="none"
height={variables.cardPreviewHeight}
width={variables.cardPreviewWidth}
/>
)}
</View>
{isCardBroken && (
<OfflineWithFeedback
Expand Down
Loading