diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts index 191c7e59c8dd..5d5efc456649 100644 --- a/src/libs/actions/User.ts +++ b/src/libs/actions/User.ts @@ -74,13 +74,6 @@ Onyx.connect({ }, }); -let allPolicies: OnyxCollection; -Onyx.connect({ - key: ONYXKEYS.COLLECTION.POLICY, - waitForCollectionCallback: true, - callback: (value) => (allPolicies = value), -}); - type DomainOnyxUpdate = | OnyxUpdate<`${typeof ONYXKEYS.COLLECTION.DOMAIN}${string}`> | OnyxUpdate<`${typeof ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${string}`> @@ -1056,6 +1049,7 @@ function generateStatementPDF(period: string) { */ function setContactMethodAsDefault( currentUserPersonalDetails: OnyxEntry, + policies: OnyxCollection, newDefaultContactMethod: string, formatPhoneNumber: LocaleContextProps['formatPhoneNumber'], backTo?: string, @@ -1156,7 +1150,7 @@ function setContactMethodAsDefault( }, ]; - for (const policy of Object.values(allPolicies ?? {})) { + for (const policy of Object.values(policies ?? {})) { if (!policy) { continue; } diff --git a/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx b/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx index e6c69723c913..b7aaedcf1d21 100644 --- a/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx +++ b/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx @@ -59,6 +59,7 @@ function ContactMethodDetailsPage({route}: ContactMethodDetailsPageProps) { const [myDomainSecurityGroups, myDomainSecurityGroupsResult] = useOnyx(ONYXKEYS.MY_DOMAIN_SECURITY_GROUPS); const [securityGroups, securityGroupsResult] = useOnyx(ONYXKEYS.COLLECTION.SECURITY_GROUP); const [isLoadingReportData = true, isLoadingReportDataResult] = useOnyx(ONYXKEYS.IS_LOADING_REPORT_DATA); + const [allPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY); const [isValidateCodeFormVisible, setIsValidateCodeFormVisible] = useState(true); const {isActingAsDelegate} = useDelegateNoAccessState(); const {showDelegateNoAccessModal} = useDelegateNoAccessActions(); @@ -93,8 +94,8 @@ function ContactMethodDetailsPage({route}: ContactMethodDetailsPageProps) { * Attempt to set this contact method as user's "Default contact method" */ const setAsDefault = useCallback(() => { - setContactMethodAsDefault(currentUserPersonalDetails, contactMethod, formatPhoneNumber, backTo); - }, [currentUserPersonalDetails, contactMethod, formatPhoneNumber, backTo]); + setContactMethodAsDefault(currentUserPersonalDetails, allPolicies, contactMethod, formatPhoneNumber, backTo); + }, [currentUserPersonalDetails, allPolicies, contactMethod, formatPhoneNumber, backTo]); /** * Determines whether the user's primary login switching is restricted