fix: the input field is announced without entered value by daledah · Pull Request #82651 · Expensify/App

daledah · 2026-02-17T13:07:22Z

Explanation of Change

Fixed Issues

$ #77547
PROPOSAL: #77547 (comment)

Tests

Prerequisites: the user is not signed in

Using iOS VoiceOver, open the Expensify app
Swipe to the 'Phone or email' input field and type the value
Swipe to refocus the input field
Listen to the VoiceOver announcement
Verify that: The focused field should be announced with its role, name and entered value.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-02-17T13:07:29Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2026-02-17T13:14:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...nput/BaseTextInput/implementation/index.native.tsx	`78.24% <100.00%> (+0.10%)`	⬆️
...s/TextInput/BaseTextInput/implementation/index.tsx	`0.00% <0.00%> (ø)`
... and 12 files with indirect coverage changes

melvin-bot · 2026-02-17T15:07:23Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2026-02-20T14:24:08Z

Hmm the behaviour of this seems somewhat inconsistent, for example on iOS the label is announced twice where as on Android it's not announced atall while editing:

Android_Native.mov

iOS_Native.mov

daledah · 2026-02-24T08:03:38Z

iOS the label is announced twice

On iOS, I only see the label announced once.

daledah · 2026-02-24T08:19:06Z

on Android it's not announced atall while editing

I can't hear anything from your video. Could you please re-upload it?

daledah · 2026-02-24T08:20:34Z

For the failing check, it passes on my side

Ollyws · 2026-02-24T14:51:36Z

I can't hear anything from your video. Could you please re-upload it?

You can see what's being announced from the subtitles at the bottom of the screen.

daledah · 2026-03-01T04:17:24Z

@Ollyws My Android simulator doesn't have the TallBack feature

@heyjennahay could you please trigger to build adhoc then i can test with the real device?

github-actions · 2026-03-02T20:11:43Z

🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here.

rushatgabhane · 2026-03-03T22:47:03Z

@Ollyws all yours

daledah · 2026-03-04T03:45:42Z

I'll try to test on the real Android device today

daledah · 2026-03-05T14:00:57Z

android-resize.mp4

@Ollyws it's working fine with the real Android device

Ollyws · 2026-03-06T09:46:19Z

@daleh I'm getting exactly the same behaviour on a real device as my earlier simulator video:

Screen_Recording_20260306_094245_Expensify.Adhoc.mp4

Ollyws · 2026-03-10T10:29:36Z

Should the ‘Phone or email’ label be announced or not?

I think the announcement should include the label, role and value. Consistently for both Android and iOS.

daledah · 2026-03-12T10:27:09Z

@Ollyws The root cause is that Android TalkBack (16.x) prioritizes reading the actual text content of EditText over contentDescription (which is what accessibilityLabel maps to on Android) — this is both a documented Android behavior and a known React Native bug.

daledah · 2026-03-12T10:27:32Z

The failing test is not related to our changes, i'll merge main to fix it soon

rushatgabhane · 2026-03-16T22:44:17Z

@Ollyws all yours

Ollyws · 2026-03-16T23:39:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: HybridApp

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

Ollyws

Aside from #82651 (comment) LGTM. Approving to keep it moving.

dangrous

looks good to me except a) conflicts and b) let's stick to the new flow for the error stuff re: https://github.com/Expensify/App/pull/82964/changes - thanks!

daledah · 2026-03-17T16:09:50Z

@dangrous i resolved conflict and updated, please check again

github-actions · 2026-03-18T16:01:05Z

🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-18T16:01:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-18T16:07:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82651.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ba8d62a-e8d9bf4-2cba843e1fd9483edd0b6f4395a63097e86ec863/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ba8d62a-e8d9bf4-09d1a8f36c1e339a044c667b758c807763b1b261/index.html

Web 🕸️
https://82651.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T20:23:36Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:25:09Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

On Android, setting accessibilityValue.text on TextInput overrides the native EditText label+content reading, causing TalkBack to drop the accessibilityLabel. This was introduced by PR Expensify#82651 to fix an iOS VoiceOver issue (Expensify#77547). By making this prop iOS-only, Android TalkBack correctly announces label + role + value while preserving the iOS VoiceOver fix. Co-authored-by: truph01 <truph01@users.noreply.github.com>

fix: the input field is announced without entered value

bea4a9d

melvin-bot Bot assigned daledah Feb 17, 2026

daledah marked this pull request as ready for review February 17, 2026 15:07

daledah requested review from a team as code owners February 17, 2026 15:07

melvin-bot Bot requested review from Ollyws and heyjennahay and removed request for a team February 17, 2026 15:07

melvin-bot Bot removed the request for review from a team February 17, 2026 15:07

daledah added 2 commits February 24, 2026 14:51

resolve conflict

d8e3272

Merge branch 'main' into fix/77547

2ce4d9b

daledah added 2 commits March 1, 2026 11:14

Merge branch 'main' into fix/77547

819460c

fix prettier

48d6524

dangrous added the Ready To Build label Mar 2, 2026

This comment has been minimized.

Sign in to view

resolve conflict

f76f84e

daledah added 2 commits March 11, 2026 14:29

resolve conflict

900d9f1

Merge branch 'main' into fix/77547

d5a1ea3

daledah added 2 commits March 12, 2026 23:24

Merge branch 'main' into fix/77547

2898cc0

resolve conflict

d63c5f4

Ollyws reviewed Mar 16, 2026

View reviewed changes

Comment thread src/components/TextInput/BaseTextInput/implementation/index.tsx Outdated

rushatgabhane requested a review from Ollyws March 16, 2026 22:25

Ollyws approved these changes Mar 16, 2026

View reviewed changes

melvin-bot Bot requested a review from dangrous March 16, 2026 23:41

dangrous suggested changes Mar 17, 2026

View reviewed changes

Comment thread src/components/TextInput/BaseTextInput/implementation/index.tsx Outdated

daledah added 2 commits March 17, 2026 22:54

resolve conflict

1bf0c5f

remove useless fallback

1cd9d5f

rushatgabhane requested a review from dangrous March 18, 2026 14:53

dangrous approved these changes Mar 18, 2026

View reviewed changes

dangrous merged commit ba8d62a into Expensify:main Mar 18, 2026
31 checks passed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

mallenexpensify mentioned this pull request Mar 20, 2026

[Due for payment 2026-03-30] [$250] Screen Reader: Many Pages: The input field is announced without entered value #77547

Closed

wildan-m mentioned this pull request May 13, 2026

[Due for payment 2026-06-01] [$250] Screen Reader: Many Pages: Field is announced without its programmatic name once any text is entered #77571

Closed

MelvinBot mentioned this pull request May 13, 2026

Fix Android TalkBack label announcement in BaseTextInput via accessibilityLabelledBy #90447

Merged

12 tasks

Conversation

daledah commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 17, 2026

Uh oh!

codecov Bot commented Feb 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Feb 17, 2026

Uh oh!

Ollyws commented Feb 20, 2026

Uh oh!

daledah commented Feb 24, 2026

Uh oh!

daledah commented Feb 24, 2026

Uh oh!

daledah commented Feb 24, 2026

Uh oh!

Ollyws commented Feb 24, 2026

Uh oh!

daledah commented Mar 1, 2026

Uh oh!

github-actions Bot commented Mar 2, 2026

Uh oh!

This comment has been minimized.

rushatgabhane commented Mar 3, 2026

Uh oh!

daledah commented Mar 4, 2026

Uh oh!

daledah commented Mar 5, 2026

Uh oh!

Ollyws commented Mar 6, 2026

Uh oh!

Ollyws commented Mar 10, 2026

Uh oh!

daledah commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daledah commented Mar 12, 2026

Uh oh!

Uh oh!

rushatgabhane commented Mar 16, 2026

Uh oh!

Ollyws commented Mar 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daledah commented Mar 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

daledah commented Feb 17, 2026 •

edited

Loading

codecov Bot commented Feb 17, 2026 •

edited by github-actions Bot

Loading

daledah commented Mar 12, 2026 •

edited

Loading