From cef44b29d3cc89f15b1b0301aeec3b1c351a8438 Mon Sep 17 00:00:00 2001 From: I Nyoman Jyotisa Date: Tue, 16 Dec 2025 09:08:17 +0800 Subject: [PATCH 1/4] Fix: Text Report title and Customize report titles are not grayed out while creating workspace in offline --- .../workspace/reports/WorkspaceReportsPage.tsx | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/pages/workspace/reports/WorkspaceReportsPage.tsx b/src/pages/workspace/reports/WorkspaceReportsPage.tsx index 272f3c22fea1..b030d4cfe2ae 100644 --- a/src/pages/workspace/reports/WorkspaceReportsPage.tsx +++ b/src/pages/workspace/reports/WorkspaceReportsPage.tsx @@ -197,14 +197,21 @@ function WorkspaceReportFieldsPage({
( + + + {translate('workspace.common.reportTitle')} + + + )} renderSubtitle={() => ( - - - + + + + + )} containerStyles={shouldUseNarrowLayout ? styles.p5 : styles.p8} - titleStyles={[styles.textHeadline, styles.cardSectionTitle, styles.accountSettingsSectionTitle, styles.mb1]} > Date: Tue, 16 Dec 2025 11:59:56 +0800 Subject: [PATCH 2/4] Fix: Text Report title and Customize report titles are not grayed out while creating workspace in offline --- src/pages/workspace/reports/WorkspaceReportsPage.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pages/workspace/reports/WorkspaceReportsPage.tsx b/src/pages/workspace/reports/WorkspaceReportsPage.tsx index b030d4cfe2ae..884e4b522612 100644 --- a/src/pages/workspace/reports/WorkspaceReportsPage.tsx +++ b/src/pages/workspace/reports/WorkspaceReportsPage.tsx @@ -198,14 +198,14 @@ function WorkspaceReportFieldsPage({
( - + {translate('workspace.common.reportTitle')} )} renderSubtitle={() => ( - + @@ -214,7 +214,7 @@ function WorkspaceReportFieldsPage({ containerStyles={shouldUseNarrowLayout ? styles.p5 : styles.p8} > Date: Tue, 16 Dec 2025 12:44:46 +0800 Subject: [PATCH 3/4] lint fix --- src/pages/workspace/reports/WorkspaceReportsPage.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/workspace/reports/WorkspaceReportsPage.tsx b/src/pages/workspace/reports/WorkspaceReportsPage.tsx index ebd888bab80f..a20220c766c9 100644 --- a/src/pages/workspace/reports/WorkspaceReportsPage.tsx +++ b/src/pages/workspace/reports/WorkspaceReportsPage.tsx @@ -214,7 +214,7 @@ function WorkspaceReportFieldsPage({ containerStyles={shouldUseNarrowLayout ? styles.p5 : styles.p8} > Date: Tue, 16 Dec 2025 13:27:54 +0800 Subject: [PATCH 4/4] Memoize renderTitle and renderSubtitle --- .../reports/WorkspaceReportsPage.tsx | 36 +++++++++++-------- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/src/pages/workspace/reports/WorkspaceReportsPage.tsx b/src/pages/workspace/reports/WorkspaceReportsPage.tsx index a20220c766c9..1c9adf70fdef 100644 --- a/src/pages/workspace/reports/WorkspaceReportsPage.tsx +++ b/src/pages/workspace/reports/WorkspaceReportsPage.tsx @@ -168,6 +168,26 @@ function WorkspaceReportFieldsPage({ const toggleTitleStyle = useMemo(() => [styles.pv2, styles.pr3], [styles.pv2, styles.pr3]); + const renderReportTitle = useCallback( + () => ( + + {translate('workspace.common.reportTitle')} + + ), + [policy?.pendingAction, styles.textHeadline, styles.cardSectionTitle, styles.accountSettingsSectionTitle, styles.mb1, translate], + ); + + const renderReportSubtitle = useCallback( + () => ( + + + + + + ), + [policy?.pendingAction, styles.renderHTML, styles.mt1, translate], + ); + return (
( - - - {translate('workspace.common.reportTitle')} - - - )} - renderSubtitle={() => ( - - - - - - )} + renderTitle={renderReportTitle} + renderSubtitle={renderReportSubtitle} containerStyles={shouldUseNarrowLayout ? styles.p5 : styles.p8} >