From cbdab1073eacf5136246e5a8c5603d7c22f1bd22 Mon Sep 17 00:00:00 2001 From: Adam Horodyski Date: Tue, 28 Oct 2025 14:03:29 +0100 Subject: [PATCH 1/3] fix: include ngrok env variables in the fingerprint for remote builds --- rock.config.mjs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rock.config.mjs b/rock.config.mjs index a5e8fbaf3964..3dff9e78fd9b 100644 --- a/rock.config.mjs +++ b/rock.config.mjs @@ -17,4 +17,7 @@ export default { ios: platformIOS({sourceDir: isHybrid ? './Mobile-Expensify/iOS' : './ios'}), android: platformAndroid({sourceDir: isHybrid ? './Mobile-Expensify/Android' : './android'}), }, + fingerprint: { + env: ['USE_NGROK', 'NGROK_URL', 'SECURE_NGROK_URL'], + }, }; From 918a6735840300de913b9c513d3d71d48fd5128d Mon Sep 17 00:00:00 2001 From: Adam Horodyski Date: Thu, 6 Nov 2025 12:05:56 +0100 Subject: [PATCH 2/3] fix: include all custom env variables in the fingerprint for remote builds --- rock.config.mjs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/rock.config.mjs b/rock.config.mjs index 3dff9e78fd9b..fff57167d4e3 100644 --- a/rock.config.mjs +++ b/rock.config.mjs @@ -2,6 +2,9 @@ import {platformAndroid} from '@rock-js/platform-android'; import {platformIOS} from '@rock-js/platform-ios'; import {pluginMetro} from '@rock-js/plugin-metro'; import {providerGitHub} from '@rock-js/provider-github'; +import dotenv from 'dotenv'; + +const env = dotenv.config(); const isHybrid = process.env.IS_HYBRID_APP === 'true'; @@ -18,6 +21,6 @@ export default { android: platformAndroid({sourceDir: isHybrid ? './Mobile-Expensify/Android' : './android'}), }, fingerprint: { - env: ['USE_NGROK', 'NGROK_URL', 'SECURE_NGROK_URL'], + env: Object.keys(env.parsed).filter((key) => key !== 'GITHUB_TOKEN'), }, }; From a96b4fc9f598ee13e2928ad62d742b8e0ff2ba90 Mon Sep 17 00:00:00 2001 From: Adam Horodyski Date: Wed, 12 Nov 2025 21:48:52 +0100 Subject: [PATCH 3/3] chore: list individual keys for rock env --- rock.config.mjs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/rock.config.mjs b/rock.config.mjs index fff57167d4e3..1dfbde8b58af 100644 --- a/rock.config.mjs +++ b/rock.config.mjs @@ -2,9 +2,6 @@ import {platformAndroid} from '@rock-js/platform-android'; import {platformIOS} from '@rock-js/platform-ios'; import {pluginMetro} from '@rock-js/plugin-metro'; import {providerGitHub} from '@rock-js/provider-github'; -import dotenv from 'dotenv'; - -const env = dotenv.config(); const isHybrid = process.env.IS_HYBRID_APP === 'true'; @@ -21,6 +18,6 @@ export default { android: platformAndroid({sourceDir: isHybrid ? './Mobile-Expensify/Android' : './android'}), }, fingerprint: { - env: Object.keys(env.parsed).filter((key) => key !== 'GITHUB_TOKEN'), + env: ['USE_WEB_PROXY', 'PUSHER_DEV_SUFFIX', 'SECURE_NGROK_URL', 'NGROK_URL', 'USE_NGROK'], }, };