From e9493863ec1b8ca6733049db0c18df9c4789387c Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Fri, 10 Oct 2025 16:09:33 +0700 Subject: [PATCH 1/5] fix: show offline indicator in RHP in wide screen part 3 --- .../NonUSD/BeneficialOwnerInfo/BeneficialOwnerInfo.tsx | 1 + .../USD/BeneficialOwnerInfo/BeneficialOwnersStep.tsx | 1 + src/pages/Travel/TravelUpgrade.tsx | 1 + src/pages/iou/request/step/IOURequestStepUpgrade.tsx | 1 + src/pages/workspace/categories/ImportedCategoriesPage.tsx | 1 + src/pages/workspace/downgrade/WorkspaceDowngradePage.tsx | 1 + src/pages/workspace/expensifyCard/issueNew/ConfirmationStep.tsx | 1 + src/pages/workspace/perDiem/ImportedPerDiemPage.tsx | 1 + src/pages/workspace/tags/ImportedMultiLevelTagsPage.tsx | 1 + src/pages/workspace/tags/ImportedTagsPage.tsx | 1 + src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx | 1 + 11 files changed, 11 insertions(+) diff --git a/src/pages/ReimbursementAccount/NonUSD/BeneficialOwnerInfo/BeneficialOwnerInfo.tsx b/src/pages/ReimbursementAccount/NonUSD/BeneficialOwnerInfo/BeneficialOwnerInfo.tsx index 4e2c75960d45..5b44b12bbc04 100644 --- a/src/pages/ReimbursementAccount/NonUSD/BeneficialOwnerInfo/BeneficialOwnerInfo.tsx +++ b/src/pages/ReimbursementAccount/NonUSD/BeneficialOwnerInfo/BeneficialOwnerInfo.tsx @@ -286,6 +286,7 @@ function BeneficialOwnerInfo({onBackButtonPress, onSubmit, stepNames}: Beneficia handleBackButtonPress={handleBackButtonPress} headerTitle={translate('ownershipInfoStep.ownerInfo')} stepNames={stepNames} + shouldShowOfflineIndicatorInWideScreen={currentSubStep === SUBSTEP.BENEFICIAL_OWNERS_LIST} startStepIndex={3} > {currentSubStep === SUBSTEP.IS_USER_BENEFICIAL_OWNER && ( diff --git a/src/pages/ReimbursementAccount/USD/BeneficialOwnerInfo/BeneficialOwnersStep.tsx b/src/pages/ReimbursementAccount/USD/BeneficialOwnerInfo/BeneficialOwnersStep.tsx index fbddd37c9111..4e6c3a66b624 100644 --- a/src/pages/ReimbursementAccount/USD/BeneficialOwnerInfo/BeneficialOwnersStep.tsx +++ b/src/pages/ReimbursementAccount/USD/BeneficialOwnerInfo/BeneficialOwnersStep.tsx @@ -215,6 +215,7 @@ function BeneficialOwnersStep({onBackButtonPress}: BeneficialOwnersStepProps) { shouldEnableMaxHeight headerTitle={translate('beneficialOwnerInfoStep.companyOwner')} handleBackButtonPress={handleBackButtonPress} + shouldShowOfflineIndicatorInWideScreen={currentUBOSubStep === SUBSTEP.UBOS_LIST} startStepIndex={5} stepNames={CONST.BANK_ACCOUNT.STEP_NAMES} > diff --git a/src/pages/Travel/TravelUpgrade.tsx b/src/pages/Travel/TravelUpgrade.tsx index 1a8d85416d63..06ed46789545 100644 --- a/src/pages/Travel/TravelUpgrade.tsx +++ b/src/pages/Travel/TravelUpgrade.tsx @@ -52,6 +52,7 @@ function TravelUpgrade({route}: TravelUpgradeProps) { shouldShowOfflineIndicator testID={TravelUpgrade.displayName} offlineIndicatorStyle={styles.mtAuto} + shouldShowOfflineIndicatorInWideScreen={!isUpgraded} > {(!!isUpgraded || !showConfirmationForm) && ( Date: Mon, 13 Oct 2025 15:37:57 +0700 Subject: [PATCH 2/5] Add offline indicator in validate code page --- .../MissingPersonalDetails/MissingPersonalDetailsContent.tsx | 1 + .../ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx | 1 + src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx | 1 + .../settings/Security/MergeAccounts/AccountValidatePage.tsx | 1 + src/pages/settings/Wallet/ReportCardLostPage.tsx | 1 + 5 files changed, 5 insertions(+) diff --git a/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx b/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx index dec00be5e973..f7bd83ca9df4 100644 --- a/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx +++ b/src/pages/MissingPersonalDetails/MissingPersonalDetailsContent.tsx @@ -112,6 +112,7 @@ function MissingPersonalDetailsContent({privatePersonalDetails, draftValues}: Mi includeSafeAreaPaddingBottom={false} shouldEnableMaxHeight testID={MissingPersonalDetailsContent.displayName} + shouldShowOfflineIndicatorInWideScreen={!!isValidateCodeActionModalVisible} > loginInputRef.current?.focus()} includeSafeAreaPaddingBottom shouldEnableMaxHeight + shouldShowOfflineIndicatorInWideScreen testID={NewContactMethodPage.displayName} > diff --git a/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx b/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx index 596126cf6217..91178c052abe 100644 --- a/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx +++ b/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx @@ -159,6 +159,7 @@ function AccountValidatePage() { shouldEnableMaxHeight includeSafeAreaPaddingBottom testID={AccountValidatePage.displayName} + shouldShowOfflineIndicatorInWideScreen > Date: Thu, 16 Oct 2025 02:53:51 +0700 Subject: [PATCH 3/5] fix ts --- src/types/utils/whitelistedReportKeys.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/types/utils/whitelistedReportKeys.ts b/src/types/utils/whitelistedReportKeys.ts index 08e2885f4474..2e90fb20d643 100644 --- a/src/types/utils/whitelistedReportKeys.ts +++ b/src/types/utils/whitelistedReportKeys.ts @@ -31,6 +31,7 @@ type WhitelistedReport = OnyxCommon.OnyxValueWithOfflineFeedback< statusNum: unknown; writeCapability: unknown; type: unknown; + created: unknown; visibility: unknown; invoiceReceiver: unknown; parentReportID: unknown; From 0ee779f1170856e0fbd74075f37848476a570e5b Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Thu, 16 Oct 2025 03:01:43 +0700 Subject: [PATCH 4/5] remove useless code --- src/types/utils/whitelistedReportKeys.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/types/utils/whitelistedReportKeys.ts b/src/types/utils/whitelistedReportKeys.ts index 2e90fb20d643..08e2885f4474 100644 --- a/src/types/utils/whitelistedReportKeys.ts +++ b/src/types/utils/whitelistedReportKeys.ts @@ -31,7 +31,6 @@ type WhitelistedReport = OnyxCommon.OnyxValueWithOfflineFeedback< statusNum: unknown; writeCapability: unknown; type: unknown; - created: unknown; visibility: unknown; invoiceReceiver: unknown; parentReportID: unknown; From 38d2e4541641ae9d2aa3f04840bc0aed29720239 Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Thu, 16 Oct 2025 03:21:48 +0700 Subject: [PATCH 5/5] fix logic show offline indicator --- src/pages/iou/request/step/IOURequestStepUpgrade.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/iou/request/step/IOURequestStepUpgrade.tsx b/src/pages/iou/request/step/IOURequestStepUpgrade.tsx index 4f7862c3713b..b00ec88094ff 100644 --- a/src/pages/iou/request/step/IOURequestStepUpgrade.tsx +++ b/src/pages/iou/request/step/IOURequestStepUpgrade.tsx @@ -146,7 +146,7 @@ function IOURequestStepUpgrade({ shouldShowOfflineIndicator testID="workspaceUpgradePage" offlineIndicatorStyle={styles.mtAuto} - shouldShowOfflineIndicatorInWideScreen={!isUpgraded} + shouldShowOfflineIndicatorInWideScreen={!isUpgraded && !showConfirmationForm} > {(!!isUpgraded || !showConfirmationForm) && (