From 329377b9946cf80681a56252ad1481ea00a5fbaa Mon Sep 17 00:00:00 2001 From: Mateo Morris Date: Thu, 6 Jan 2022 11:18:22 -0500 Subject: [PATCH 1/2] Make about footer links accessible --- src/pages/settings/AboutPage/index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pages/settings/AboutPage/index.js b/src/pages/settings/AboutPage/index.js index dbd021b356b8..47d6a89dfa2a 100644 --- a/src/pages/settings/AboutPage/index.js +++ b/src/pages/settings/AboutPage/index.js @@ -116,8 +116,8 @@ const AboutPage = (props) => { )} {' '} Link.openExternalLink(CONST.TERMS_URL)} + style={[styles.textMicroSupporting, styles.link]} + href={CONST.TERMS_URL} > {props.translate( 'initialSettingsPage.readTheTermsAndPrivacyPolicy.phrase2', @@ -129,8 +129,8 @@ const AboutPage = (props) => { )} {' '} Link.openExternalLink(CONST.PRIVACY_URL)} + style={[styles.textMicroSupporting, styles.link]} + href={CONST.PRIVACY_URL} > {props.translate( 'initialSettingsPage.readTheTermsAndPrivacyPolicy.phrase4', From 724aa859c6d2637601516bda2bafa446a1f7e2f0 Mon Sep 17 00:00:00 2001 From: Mateo Morris Date: Mon, 17 Jan 2022 13:05:35 -0500 Subject: [PATCH 2/2] Use accessibilityRole instead of href to enable opening in new tab --- src/pages/settings/AboutPage/index.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pages/settings/AboutPage/index.js b/src/pages/settings/AboutPage/index.js index 47d6a89dfa2a..4f7ff002bb0a 100644 --- a/src/pages/settings/AboutPage/index.js +++ b/src/pages/settings/AboutPage/index.js @@ -116,8 +116,9 @@ const AboutPage = (props) => { )} {' '} Link.openExternalLink(CONST.TERMS_URL)} > {props.translate( 'initialSettingsPage.readTheTermsAndPrivacyPolicy.phrase2', @@ -129,8 +130,9 @@ const AboutPage = (props) => { )} {' '} Link.openExternalLink(CONST.PRIVACY_URL)} > {props.translate( 'initialSettingsPage.readTheTermsAndPrivacyPolicy.phrase4',