From 718e7821f6e9a8650b7223dc3d6b2d6069db8e2c Mon Sep 17 00:00:00 2001 From: gijoe0295 <153004152+gijoe0295@users.noreply.github.com> Date: Thu, 5 Jun 2025 00:57:13 +0700 Subject: [PATCH 1/3] fix: auto-pay approved reports can be enabled when payment is disabled --- src/pages/workspace/rules/ExpenseReportRulesSection.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/workspace/rules/ExpenseReportRulesSection.tsx b/src/pages/workspace/rules/ExpenseReportRulesSection.tsx index 99c205badf45..3f2c993b1d7d 100644 --- a/src/pages/workspace/rules/ExpenseReportRulesSection.tsx +++ b/src/pages/workspace/rules/ExpenseReportRulesSection.tsx @@ -9,7 +9,7 @@ import usePolicy from '@hooks/usePolicy'; import useThemeStyles from '@hooks/useThemeStyles'; import {convertToDisplayString} from '@libs/CurrencyUtils'; import Navigation from '@libs/Navigation/Navigation'; -import {getWorkflowApprovalsUnavailable} from '@libs/PolicyUtils'; +import {getWorkflowApprovalsUnavailable, hasVBBA} from '@libs/PolicyUtils'; import ToggleSettingOptionRow from '@pages/workspace/workflows/ToggleSettingsOptionRow'; import {enableAutoApprovalOptions, enablePolicyAutoReimbursementLimit, setPolicyPreventSelfApproval} from '@userActions/Policy/Policy'; import CONST from '@src/CONST'; @@ -24,7 +24,7 @@ function ExpenseReportRulesSection({policyID}: ExpenseReportRulesSectionProps) { const styles = useThemeStyles(); const policy = usePolicy(policyID); const workflowApprovalsUnavailable = getWorkflowApprovalsUnavailable(policy); - const autoPayApprovedReportsUnavailable = policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO; + const autoPayApprovedReportsUnavailable = !policy?.areWorkflowsEnabled || policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO || !hasVBBA(policyID); const renderFallbackSubtitle = ({featureName, variant = 'unlock'}: {featureName: string; variant?: 'unlock' | 'enable'}) => { return ( From ea8dcea997db3e0a2a9bd366f415598758332a69 Mon Sep 17 00:00:00 2001 From: gijoe0295 <153004152+gijoe0295@users.noreply.github.com> Date: Thu, 5 Jun 2025 01:05:10 +0700 Subject: [PATCH 2/3] only allow direct reimbursement --- src/pages/workspace/rules/ExpenseReportRulesSection.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/workspace/rules/ExpenseReportRulesSection.tsx b/src/pages/workspace/rules/ExpenseReportRulesSection.tsx index 3f2c993b1d7d..0a7bb0b8b8ea 100644 --- a/src/pages/workspace/rules/ExpenseReportRulesSection.tsx +++ b/src/pages/workspace/rules/ExpenseReportRulesSection.tsx @@ -24,7 +24,7 @@ function ExpenseReportRulesSection({policyID}: ExpenseReportRulesSectionProps) { const styles = useThemeStyles(); const policy = usePolicy(policyID); const workflowApprovalsUnavailable = getWorkflowApprovalsUnavailable(policy); - const autoPayApprovedReportsUnavailable = !policy?.areWorkflowsEnabled || policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO || !hasVBBA(policyID); + const autoPayApprovedReportsUnavailable = !policy?.areWorkflowsEnabled || policy?.reimbursementChoice !== CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_YES || !hasVBBA(policyID); const renderFallbackSubtitle = ({featureName, variant = 'unlock'}: {featureName: string; variant?: 'unlock' | 'enable'}) => { return ( From d4ea197d573a059c25a311af59eccd8b92ee45c1 Mon Sep 17 00:00:00 2001 From: gijoe0295 <153004152+gijoe0295@users.noreply.github.com> Date: Thu, 5 Jun 2025 19:21:01 +0700 Subject: [PATCH 3/3] use label font size for subtitle --- src/pages/workspace/rules/ExpenseReportRulesSection.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pages/workspace/rules/ExpenseReportRulesSection.tsx b/src/pages/workspace/rules/ExpenseReportRulesSection.tsx index 0a7bb0b8b8ea..9e8c0d3c3558 100644 --- a/src/pages/workspace/rules/ExpenseReportRulesSection.tsx +++ b/src/pages/workspace/rules/ExpenseReportRulesSection.tsx @@ -29,17 +29,17 @@ function ExpenseReportRulesSection({policyID}: ExpenseReportRulesSectionProps) { const renderFallbackSubtitle = ({featureName, variant = 'unlock'}: {featureName: string; variant?: 'unlock' | 'enable'}) => { return ( - {translate('workspace.rules.expenseReportRules.unlockFeatureGoToSubtitle')}{' '} + {translate('workspace.rules.expenseReportRules.unlockFeatureGoToSubtitle')}{' '} Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID))} > {translate('workspace.common.moreFeatures').toLowerCase()} {' '} {variant === 'unlock' ? ( - {translate('workspace.rules.expenseReportRules.unlockFeatureEnableWorkflowsSubtitle', {featureName})} + {translate('workspace.rules.expenseReportRules.unlockFeatureEnableWorkflowsSubtitle', {featureName})} ) : ( - {translate('workspace.rules.expenseReportRules.enableFeatureSubtitle', {featureName})} + {translate('workspace.rules.expenseReportRules.enableFeatureSubtitle', {featureName})} )} );