diff --git a/src/components/FeatureTrainingModal.tsx b/src/components/FeatureTrainingModal.tsx index b8559c208fe9..f35c620d2521 100644 --- a/src/components/FeatureTrainingModal.tsx +++ b/src/components/FeatureTrainingModal.tsx @@ -343,7 +343,6 @@ function FeatureTrainingModal({ return ( ; } @@ -82,7 +82,6 @@ function BaseModal( shouldPreventScrollOnFocus = false, enableEdgeToEdgeBottomSafeAreaPadding, shouldApplySidePanelOffset = type === CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED, - id, }: BaseModalProps, ref: React.ForwardedRef, ) { @@ -308,7 +307,6 @@ function BaseModal( avoidKeyboard={avoidKeyboard} customBackdrop={shouldUseCustomBackdrop ? : undefined} type={type} - id={id} > { onCloseCallbackRef.current = onCloseCallBack; }, [onCloseCallBack]); - const Entering = useMemo(() => { - const FadeIn = new Keyframe({ - from: {opacity: 0}, - to: { - opacity: 1, - easing, - }, - }); + useEffect(() => { + if (isInitiated.get()) { + return; + } + isInitiated.set(true); + opacity.set(withTiming(1, {duration: animationInTiming, easing}, onOpenCallBack)); + }, [animationInTiming, onOpenCallBack, opacity, isInitiated]); - return FadeIn.duration(animationInTiming).withCallback(onOpenCallBack); - }, [animationInTiming, onOpenCallBack]); + const animatedStyles = useAnimatedStyle(() => ({opacity: opacity.get()}), [opacity]); const Exiting = useMemo(() => { const FadeOut = new Keyframe({ @@ -41,9 +41,8 @@ function Container({style, animationInTiming = 300, animationOutTiming = 300, on return ( diff --git a/src/components/Modal/BottomDockedModal/index.tsx b/src/components/Modal/BottomDockedModal/index.tsx index 1968a10ca53e..27d16d12abc6 100644 --- a/src/components/Modal/BottomDockedModal/index.tsx +++ b/src/components/Modal/BottomDockedModal/index.tsx @@ -1,8 +1,9 @@ import noop from 'lodash/noop'; import React, {useCallback, useEffect, useMemo, useRef, useState} from 'react'; import type {NativeEventSubscription, ViewStyle} from 'react-native'; -import {BackHandler, Dimensions, InteractionManager, KeyboardAvoidingView, Modal, View} from 'react-native'; +import {BackHandler, Dimensions, InteractionManager, Modal, View} from 'react-native'; import {LayoutAnimationConfig} from 'react-native-reanimated'; +import KeyboardAvoidingView from '@components/KeyboardAvoidingView'; import useThemeStyles from '@hooks/useThemeStyles'; import getPlatform from '@libs/getPlatform'; import CONST from '@src/CONST';