diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts index 86d302440567..5f0ef6b2ed92 100644 --- a/src/libs/actions/IOU.ts +++ b/src/libs/actions/IOU.ts @@ -4705,14 +4705,9 @@ function convertTrackedExpenseToRequest(convertTrackedExpenseParams: ConvertTrac attendees, transactionThreadReportID, } = transactionParams; - const {optimisticData, successData, failureData} = onyxData; + const {optimisticData: convertTransactionOptimisticData = [], successData: convertTransactionSuccessData = [], failureData: convertTransactionFailureData = []} = onyxData; - const { - optimisticData: moveTransactionOptimisticData, - successData: moveTransactionSuccessData, - failureData: moveTransactionFailureData, - modifiedExpenseReportActionID, - } = getConvertTrackedExpenseInformation( + const {optimisticData, successData, failureData, modifiedExpenseReportActionID} = getConvertTrackedExpenseInformation( transactionID, actionableWhisperReportActionID, iouParams.reportID, @@ -4722,9 +4717,9 @@ function convertTrackedExpenseToRequest(convertTrackedExpenseParams: ConvertTrac CONST.IOU.ACTION.SUBMIT, ); - optimisticData?.push(...moveTransactionOptimisticData); - successData?.push(...moveTransactionSuccessData); - failureData?.push(...moveTransactionFailureData); + optimisticData?.push(...convertTransactionOptimisticData); + successData?.push(...convertTransactionSuccessData); + failureData?.push(...convertTransactionFailureData); if (workspaceParams) { const params = { @@ -4824,7 +4819,7 @@ function categorizeTrackedExpense(trackedExpenseParams: TrackedExpenseParams) { function shareTrackedExpense(trackedExpenseParams: TrackedExpenseParams) { const {onyxData, reportInformation, transactionParams, policyParams, createdWorkspaceParams} = trackedExpenseParams; - const {optimisticData, successData, failureData} = onyxData ?? {}; + const {optimisticData: shareTrackedExpenseOptimisticData = [], successData: shareTrackedExpenseSuccessData = [], failureData: shareTrackedExpenseFailureData = []} = onyxData ?? {}; const {transactionID} = transactionParams; const { actionableWhisperReportActionID, @@ -4837,12 +4832,7 @@ function shareTrackedExpense(trackedExpenseParams: TrackedExpenseParams) { transactionThreadReportID, } = reportInformation; - const { - optimisticData: moveTransactionOptimisticData, - successData: moveTransactionSuccessData, - failureData: moveTransactionFailureData, - modifiedExpenseReportActionID, - } = getConvertTrackedExpenseInformation( + const {optimisticData, successData, failureData, modifiedExpenseReportActionID} = getConvertTrackedExpenseInformation( transactionID, actionableWhisperReportActionID, moneyRequestReportID, @@ -4852,9 +4842,9 @@ function shareTrackedExpense(trackedExpenseParams: TrackedExpenseParams) { CONST.IOU.ACTION.SHARE, ); - optimisticData?.push(...moveTransactionOptimisticData); - successData?.push(...moveTransactionSuccessData); - failureData?.push(...moveTransactionFailureData); + optimisticData?.push(...shareTrackedExpenseOptimisticData); + successData?.push(...shareTrackedExpenseSuccessData); + failureData?.push(...shareTrackedExpenseFailureData); const parameters: ShareTrackedExpenseParams = { ...transactionParams,