From 2ea608e840c180d065ff31679797ae2c8cc9c508 Mon Sep 17 00:00:00 2001 From: Alberto Date: Wed, 16 Apr 2025 16:01:45 +0200 Subject: [PATCH 1/2] remove newDotPDFExport beta --- src/CONST.ts | 1 - src/libs/Permissions.ts | 5 ----- src/pages/ReportDetailsPage.tsx | 30 +++++++++++++----------------- 3 files changed, 13 insertions(+), 23 deletions(-) diff --git a/src/CONST.ts b/src/CONST.ts index 4af1d3c79a45..8b539dc81800 100755 --- a/src/CONST.ts +++ b/src/CONST.ts @@ -789,7 +789,6 @@ const CONST = { PER_DIEM: 'newDotPerDiem', NEWDOT_MERGE_ACCOUNTS: 'newDotMergeAccounts', NEWDOT_MANAGER_MCTEST: 'newDotManagerMcTest', - NEWDOT_PDF_EXPORT: 'newDotPDFExport', NEW_DOT_TALK_TO_AI_SALES: 'newDotTalkToAISales', CUSTOM_RULES: 'customRules', TABLE_REPORT_VIEW: 'tableReportView', diff --git a/src/libs/Permissions.ts b/src/libs/Permissions.ts index 8698ed2c7e17..35d6d5bc5b26 100644 --- a/src/libs/Permissions.ts +++ b/src/libs/Permissions.ts @@ -34,10 +34,6 @@ function canUseMergeAccounts(betas: OnyxEntry): boolean { return !!betas?.includes(CONST.BETAS.NEWDOT_MERGE_ACCOUNTS) || canUseAllBetas(betas); } -function canUsePDFExport(betas: OnyxEntry): boolean { - return !!betas?.includes(CONST.BETAS.NEWDOT_PDF_EXPORT) || canUseAllBetas(betas); -} - function canUseManagerMcTest(betas: OnyxEntry): boolean { return !!betas?.includes(CONST.BETAS.NEWDOT_MANAGER_MCTEST) || canUseAllBetas(betas); } @@ -72,7 +68,6 @@ export default { canUseSpotnanaTravel, isBlockedFromSpotnanaTravel, canUseNetSuiteUSATax, - canUsePDFExport, canUseMergeAccounts, canUseManagerMcTest, canUseCustomRules, diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx index 999ec3483960..d71901598ff5 100644 --- a/src/pages/ReportDetailsPage.tsx +++ b/src/pages/ReportDetailsPage.tsx @@ -164,7 +164,6 @@ type CaseID = ValueOf; function ReportDetailsPage({policies, report, route, reportMetadata}: ReportDetailsPageProps) { const {translate} = useLocalize(); const {isOffline} = useNetwork(); - const {canUsePDFExport} = usePermissions(); const theme = useTheme(); const styles = useThemeStyles(); const backTo = route.params.backTo; @@ -572,21 +571,19 @@ function ReportDetailsPage({policies, report, route, reportMetadata}: ReportDeta }); }, }); - if (canUsePDFExport) { - items.push({ - key: CONST.REPORT_DETAILS_MENU_ITEM.DOWNLOAD_PDF, - translationKey: 'common.downloadAsPDF', - icon: Expensicons.Document, - isAnonymousAction: false, - action: () => { - if (isOffline) { - setOfflineModalVisible(true); - } else { - beginPDFExport(); - } - }, - }); - } + items.push({ + key: CONST.REPORT_DETAILS_MENU_ITEM.DOWNLOAD_PDF, + translationKey: 'common.downloadAsPDF', + icon: Expensicons.Document, + isAnonymousAction: false, + action: () => { + if (isOffline) { + setOfflineModalVisible(true); + } else { + beginPDFExport(); + } + }, + }); } if (policy && connectedIntegration && isPolicyAdmin && !isSingleTransactionView && isExpenseReport) { @@ -658,7 +655,6 @@ function ReportDetailsPage({policies, report, route, reportMetadata}: ReportDeta return items; }, [ beginPDFExport, - canUsePDFExport, isSelfDM, isArchivedRoom, isGroupChat, From 3f02b859661c92414e943349d90561dbb0370055 Mon Sep 17 00:00:00 2001 From: Alberto Date: Wed, 16 Apr 2025 16:14:58 +0200 Subject: [PATCH 2/2] remove usePermissions --- src/pages/ReportDetailsPage.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx index d71901598ff5..1d7f73dd0672 100644 --- a/src/pages/ReportDetailsPage.tsx +++ b/src/pages/ReportDetailsPage.tsx @@ -36,7 +36,6 @@ import useDelegateUserDetails from '@hooks/useDelegateUserDetails'; import useLocalize from '@hooks/useLocalize'; import useNetwork from '@hooks/useNetwork'; import usePaginatedReportActions from '@hooks/usePaginatedReportActions'; -import usePermissions from '@hooks/usePermissions'; import useResponsiveLayout from '@hooks/useResponsiveLayout'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles';