From 6f712036fe33a2b9ecf77d09c17036d0ec2bcf52 Mon Sep 17 00:00:00 2001 From: Carlos Miceli Date: Mon, 31 Mar 2025 19:25:39 -0300 Subject: [PATCH 1/4] add report action for delete tag list --- src/CONST.ts | 1 + src/libs/ReportActionsUtils.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/CONST.ts b/src/CONST.ts index 0f01edb87cde..686bc0753e38 100755 --- a/src/CONST.ts +++ b/src/CONST.ts @@ -1259,6 +1259,7 @@ const CONST = { DELETE_INTEGRATION: 'POLICYCHANGELOG_DELETE_INTEGRATION', DELETE_REPORT_FIELD: 'POLICYCHANGELOG_DELETE_REPORT_FIELD', DELETE_TAG: 'POLICYCHANGELOG_DELETE_TAG', + DELETE_TAG_LIST: 'POLICYCHANGELOG_DELETE_TAG_LIST', IMPORT_CUSTOM_UNIT_RATES: 'POLICYCHANGELOG_IMPORT_CUSTOM_UNIT_RATES', IMPORT_TAGS: 'POLICYCHANGELOG_IMPORT_TAGS', INDIVIDUAL_BUDGET_NOTIFICATION: 'POLICYCHANGELOG_INDIVIDUAL_BUDGET_NOTIFICATION', diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts index 9bfdfafb0c46..e438a310ceeb 100644 --- a/src/libs/ReportActionsUtils.ts +++ b/src/libs/ReportActionsUtils.ts @@ -1131,6 +1131,7 @@ function isTagModificationAction(actionName: string): boolean { actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG_ENABLED || actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG_NAME || actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_TAG || + actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_TAG_LIST || actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG ); } From 724ccd2b2ecaae5d9f4ebb6af87a8162e511cd88 Mon Sep 17 00:00:00 2001 From: Carlos Miceli Date: Mon, 31 Mar 2025 19:51:22 -0300 Subject: [PATCH 2/4] add deleteTagList workspace action --- src/languages/en.ts | 1 + src/languages/es.ts | 1 + src/libs/ReportActionsUtils.ts | 6 ++++++ 3 files changed, 8 insertions(+) diff --git a/src/languages/en.ts b/src/languages/en.ts index 48a9842a7cd9..0890fbaf52c5 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -4945,6 +4945,7 @@ const translations = { updateTagName: ({tagListName, newName, oldName}: UpdatedPolicyTagNameParams) => `updated the tag list "${tagListName}" by changing the tag "${oldName}" to "${newName}`, updateTagEnabled: ({tagListName, tagName, enabled}: UpdatedPolicyTagParams) => `${enabled ? 'enabled' : 'disabled'} the tag "${tagName}" on the list "${tagListName}"`, deleteTag: ({tagListName, tagName}: UpdatedPolicyTagParams) => `removed the tag "${tagName}" from the list "${tagListName}"`, + deleteTagList: ({tagListName}: UpdatedPolicyTagParams) => `removed multiple tags from the list "${tagListName}"`, updateTag: ({tagListName, newValue, tagName, updatedField, oldValue}: UpdatedPolicyTagFieldParams) => { if (oldValue) { return `updated the tag "${tagName}" on the list "${tagListName}" by changing the ${updatedField} to "${newValue}" (previously "${oldValue}")`; diff --git a/src/languages/es.ts b/src/languages/es.ts index 47ac36ce01bf..482d7f93432a 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -4996,6 +4996,7 @@ const translations = { updateTagName: ({tagListName, newName, oldName}: UpdatedPolicyTagNameParams) => `actualizó la lista de etiquetas "${tagListName}" cambiando la etiqueta "${oldName}" a "${newName}"`, updateTagEnabled: ({tagListName, tagName, enabled}: UpdatedPolicyTagParams) => `${enabled ? 'habilitó' : 'deshabilitó'} la etiqueta "${tagName}" en la lista "${tagListName}"`, deleteTag: ({tagListName, tagName}: UpdatedPolicyTagParams) => `eliminó la etiqueta "${tagName}" de la lista "${tagListName}"`, + deleteTagList: ({tagListName}: UpdatedPolicyTagParams) => `eliminó múltiples etiquetas de la lista "${tagListName}"`, updateTag: ({tagListName, newValue, tagName, updatedField, oldValue}: UpdatedPolicyTagFieldParams) => { if (oldValue) { return `actualizó la etiqueta "${tagName}" en la lista "${tagListName}" cambiando el ${updatedField} a "${newValue}" (previamente "${oldValue}")`; diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts index e438a310ceeb..c2d465d1665d 100644 --- a/src/libs/ReportActionsUtils.ts +++ b/src/libs/ReportActionsUtils.ts @@ -1948,6 +1948,12 @@ function getWorkspaceTagUpdateMessage(action: ReportAction): string { }); } + if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_TAG_LIST && tagListName) { + return translateLocal('workspaceActions.deleteTagList', { + tagListName + }); + } + if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_TAG_ENABLED && tagListName && tagName) { return translateLocal('workspaceActions.updateTagEnabled', { tagListName, From 725e848715dc4d209c169cd889396a91ebb08934 Mon Sep 17 00:00:00 2001 From: Carlos Miceli Date: Mon, 31 Mar 2025 19:51:54 -0300 Subject: [PATCH 3/4] fix param optional --- src/languages/params.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/languages/params.ts b/src/languages/params.ts index d17a712b46cd..8cd0b9d58b1c 100644 --- a/src/languages/params.ts +++ b/src/languages/params.ts @@ -303,7 +303,7 @@ type UpdatedPolicyCurrencyParams = {oldCurrency: string; newCurrency: string}; type UpdatedPolicyCategoryParams = {categoryName: string; oldValue?: boolean}; -type UpdatedPolicyTagParams = {tagListName: string; tagName: string; enabled?: boolean}; +type UpdatedPolicyTagParams = {tagListName: string; tagName?: string; enabled?: boolean}; type UpdatedPolicyTagNameParams = {oldName: string; newName: string; tagListName: string}; From 96562a9c5a131dc6141f4866a7c94d284639dd2e Mon Sep 17 00:00:00 2001 From: Carlos Miceli Date: Mon, 31 Mar 2025 19:55:02 -0300 Subject: [PATCH 4/4] prettier --- src/libs/ReportActionsUtils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts index c2d465d1665d..18dcf9355229 100644 --- a/src/libs/ReportActionsUtils.ts +++ b/src/libs/ReportActionsUtils.ts @@ -1950,7 +1950,7 @@ function getWorkspaceTagUpdateMessage(action: ReportAction): string { if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_TAG_LIST && tagListName) { return translateLocal('workspaceActions.deleteTagList', { - tagListName + tagListName, }); }