From f57b0767ce7ff7f2200f68d234b1cfed53029947 Mon Sep 17 00:00:00 2001 From: Scott Deeter Date: Wed, 26 Mar 2025 13:58:16 -0700 Subject: [PATCH 1/3] Hide the REIMBURSED action type --- src/pages/home/report/PureReportActionItem.tsx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pages/home/report/PureReportActionItem.tsx b/src/pages/home/report/PureReportActionItem.tsx index c67baace9820..2abf58e9721b 100644 --- a/src/pages/home/report/PureReportActionItem.tsx +++ b/src/pages/home/report/PureReportActionItem.tsx @@ -1161,6 +1161,12 @@ function PureReportActionItem({ return null; } + // The REIMBURSED report action type is only supported in OldDot so we need to hide them in NewDot since the + // information they display is already provided by other actions. + if (action.actionName === CONST.REPORT.ACTIONS.TYPE.REIMBURSED) { + return null; + } + const hasErrors = !isEmptyObject(action.errors); const whisperedTo = getWhisperedTo(action); const isMultipleParticipant = whisperedTo.length > 1; From 0178ce8faf8ab39782ec22feb309fe0c39b3e47e Mon Sep 17 00:00:00 2001 From: Scott Deeter Date: Thu, 27 Mar 2025 15:14:48 -0700 Subject: [PATCH 2/3] Add REIMBURSED to the list of deprecated OldDot actions --- src/libs/ReportActionsUtils.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts index c05a16f2c992..9bfdfafb0c46 100644 --- a/src/libs/ReportActionsUtils.ts +++ b/src/libs/ReportActionsUtils.ts @@ -718,6 +718,7 @@ function isReportActionDeprecated(reportAction: OnyxEntry, key: st CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_REQUESTED, CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_SETUP_REQUESTED, CONST.REPORT.ACTIONS.TYPE.DONATION, + CONST.REPORT.ACTIONS.TYPE.REIMBURSED, ]; if (deprecatedOldDotReportActions.includes(reportAction.actionName)) { Log.info('Front end filtered out reportAction for being an older, deprecated report action', false, reportAction); From 5b83820c5ccfc210dd9c0047fc99b317581338fc Mon Sep 17 00:00:00 2001 From: Scott Deeter Date: Thu, 27 Mar 2025 15:15:57 -0700 Subject: [PATCH 3/3] Revert "Hide the REIMBURSED action type" This reverts commit f57b0767ce7ff7f2200f68d234b1cfed53029947. --- src/pages/home/report/PureReportActionItem.tsx | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/pages/home/report/PureReportActionItem.tsx b/src/pages/home/report/PureReportActionItem.tsx index 2abf58e9721b..c67baace9820 100644 --- a/src/pages/home/report/PureReportActionItem.tsx +++ b/src/pages/home/report/PureReportActionItem.tsx @@ -1161,12 +1161,6 @@ function PureReportActionItem({ return null; } - // The REIMBURSED report action type is only supported in OldDot so we need to hide them in NewDot since the - // information they display is already provided by other actions. - if (action.actionName === CONST.REPORT.ACTIONS.TYPE.REIMBURSED) { - return null; - } - const hasErrors = !isEmptyObject(action.errors); const whisperedTo = getWhisperedTo(action); const isMultipleParticipant = whisperedTo.length > 1;