From 271d55e37bfbc9c6c5e37008b7fe9a0dac05f286 Mon Sep 17 00:00:00 2001 From: Andrew Gable Date: Tue, 28 Jan 2025 15:19:30 -0700 Subject: [PATCH 1/3] Remove $ to fix Google Geolocation API --- .github/workflows/deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index fab1604f1ee4..0c6ffd4306f7 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -322,7 +322,7 @@ jobs: APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - GCP_GEOLOCATION_API_KEY: $${{ secrets.GCP_GEOLOCATION_API_KEY_PRODUCTION }} + GCP_GEOLOCATION_API_KEY: ${{ secrets.GCP_GEOLOCATION_API_KEY_PRODUCTION }} - name: Upload desktop sourcemaps artifact uses: actions/upload-artifact@v4 From 495ff58f73d0ad0426bf2b22263e90feac0864e1 Mon Sep 17 00:00:00 2001 From: Andrew Gable Date: Tue, 28 Jan 2025 15:20:57 -0700 Subject: [PATCH 2/3] Fix on AdHoc build as well --- .github/workflows/testBuild.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/testBuild.yml b/.github/workflows/testBuild.yml index d00781fa2a32..869db3d04be7 100644 --- a/.github/workflows/testBuild.yml +++ b/.github/workflows/testBuild.yml @@ -270,7 +270,7 @@ jobs: APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - GCP_GEOLOCATION_API_KEY: $${{ secrets.GCP_GEOLOCATION_API_KEY_STAGING }} + GCP_GEOLOCATION_API_KEY: ${{ secrets.GCP_GEOLOCATION_API_KEY_STAGING }} web: name: Build and deploy Web From dbacd7fc707fa56850532c65ac8e7c9cc3833464 Mon Sep 17 00:00:00 2001 From: Andrew Gable Date: Tue, 28 Jan 2025 17:14:32 -0700 Subject: [PATCH 3/3] Add a newline to end of staging env --- .env.staging | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.env.staging b/.env.staging index 17d82ac2d136..c789087ebded 100644 --- a/.env.staging +++ b/.env.staging @@ -6,4 +6,4 @@ EXPENSIFY_PARTNER_PASSWORD=e21965746fd75f82bb66 PUSHER_APP_KEY=268df511a204fbb60884 USE_WEB_PROXY=false ENVIRONMENT=staging -SEND_CRASH_REPORTS=true \ No newline at end of file +SEND_CRASH_REPORTS=true