From b158eeb380ff8e8f4d44fed97b52d560200bf3a8 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Mon, 11 Nov 2024 10:50:03 +0800 Subject: [PATCH] fix hidden members is shown when creating workspace from iou payment --- src/libs/actions/Policy/Policy.ts | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/libs/actions/Policy/Policy.ts b/src/libs/actions/Policy/Policy.ts index d87f0321bab0..09c5825d8ce3 100644 --- a/src/libs/actions/Policy/Policy.ts +++ b/src/libs/actions/Policy/Policy.ts @@ -2143,7 +2143,6 @@ function createWorkspaceFromIOUPayment(iouReport: OnyxEntry): WorkspaceF const policyID = generatePolicyID(); const workspaceName = generateDefaultWorkspaceName(sessionEmail); const employeeAccountID = iouReport.ownerAccountID; - const employeeEmail = iouReport.ownerEmail ?? ''; const {customUnits, customUnitID, customUnitRateID} = buildOptimisticDistanceRateCustomUnits(iouReport.currency); const oldPersonalPolicyID = iouReport.policyID; const iouReportID = iouReport.reportID; @@ -2163,6 +2162,8 @@ function createWorkspaceFromIOUPayment(iouReport: OnyxEntry): WorkspaceF return; } + const employeeEmail = allPersonalDetails?.[employeeAccountID]?.login ?? ''; + // Create the workspace chat for the employee whose IOU is being paid const employeeWorkspaceChat = createPolicyExpenseChats(policyID, {[employeeEmail]: employeeAccountID}, true); const newWorkspace = { @@ -2197,10 +2198,14 @@ function createWorkspaceFromIOUPayment(iouReport: OnyxEntry): WorkspaceF role: CONST.POLICY.ROLE.ADMIN, errors: {}, }, - [employeeEmail]: { - role: CONST.POLICY.ROLE.USER, - errors: {}, - }, + ...(employeeEmail + ? { + [employeeEmail]: { + role: CONST.POLICY.ROLE.USER, + errors: {}, + }, + } + : {}), }, pendingFields: { autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,