From 1a1937e1b330665703cad8694a9df4c8686230ef Mon Sep 17 00:00:00 2001 From: dominictb Date: Fri, 16 Aug 2024 00:53:48 +0700 Subject: [PATCH] fix Final confirmation is displayed in the review duplicates flow --- src/libs/TransactionUtils/index.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/libs/TransactionUtils/index.ts b/src/libs/TransactionUtils/index.ts index a865b78a9bbf..b0b20c7eaf3a 100644 --- a/src/libs/TransactionUtils/index.ts +++ b/src/libs/TransactionUtils/index.ts @@ -954,11 +954,6 @@ function compareDuplicateTransactionFields(transactionID: string): {keep: Partia return items.every((item) => lodashIsEqual(item?.comment, firstTransaction?.comment)); } - // Helper function to check if all comments exist - function doAllCommentsExist(items: Array>, firstTransaction: OnyxEntry) { - return items.every((item) => !!item?.comment?.comment === !!firstTransaction?.comment?.comment); - } - // Helper function to check if all fields are equal for a given key function areAllFieldsEqual(items: Array>, keyExtractor: (item: OnyxEntry) => string) { const firstTransaction = transactions[0]; @@ -981,10 +976,9 @@ function compareDuplicateTransactionFields(transactionID: string): {keep: Partia if (fieldName === 'description') { const allCommentsAreEqual = areAllCommentsEqual(transactions, firstTransaction); - const allCommentsExist = doAllCommentsExist(transactions, firstTransaction); const allCommentsAreEmpty = isFirstTransactionCommentEmptyObject && transactions.every((item) => item?.comment === undefined); - if (allCommentsAreEqual || allCommentsExist || allCommentsAreEmpty) { + if (allCommentsAreEqual || allCommentsAreEmpty) { keep[fieldName] = firstTransaction?.comment?.comment ?? firstTransaction?.comment; } else { processChanges(fieldName, transactions, keys);