From 19a76a981e268d9a348b88dcd6a21096488e24f6 Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Thu, 1 Aug 2024 13:37:19 +0200 Subject: [PATCH 1/2] fix: announce e2e build failures --- .../composite/buildAndroidE2EAPK/action.yml | 20 +++++++++++++++++++ .github/workflows/e2ePerformanceTests.yml | 4 +++- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/.github/actions/composite/buildAndroidE2EAPK/action.yml b/.github/actions/composite/buildAndroidE2EAPK/action.yml index cfce0d3ec7d8..424f6150f01c 100644 --- a/.github/actions/composite/buildAndroidE2EAPK/action.yml +++ b/.github/actions/composite/buildAndroidE2EAPK/action.yml @@ -37,6 +37,9 @@ inputs: EXPENSIFY_PARTNER_PASSWORD_EMAIL: description: The email address of the Expensify partner to use for the build required: true + SLACK_WEBHOOK_URL: + description: 'URL of the slack webhook' + required: true runs: using: composite @@ -75,6 +78,23 @@ runs: env: RUBYOPT: '-rostruct' + - name: Announce failed workflow in Slack + if: failure() + uses: 8398a7/action-slack@v3 + with: + status: custom + custom_payload: | + { + channel: '#e2e-announce', + attachments: [{ + color: 'danger', + text: `💥 ${process.env.AS_REPO} E2E APK build run failed on workflow 💥`, + }] + } + env: + GITHUB_TOKEN: ${{ github.token }} + SLACK_WEBHOOK_URL: ${{ inputs.SLACK_WEBHOOK_URL }} + - name: Upload APK uses: actions/upload-artifact@v4 with: diff --git a/.github/workflows/e2ePerformanceTests.yml b/.github/workflows/e2ePerformanceTests.yml index 617a7a0abe05..e57556143978 100644 --- a/.github/workflows/e2ePerformanceTests.yml +++ b/.github/workflows/e2ePerformanceTests.yml @@ -68,6 +68,7 @@ jobs: EXPENSIFY_PARTNER_USER_ID: ${{ secrets.EXPENSIFY_PARTNER_USER_ID }} EXPENSIFY_PARTNER_USER_SECRET: ${{ secrets.EXPENSIFY_PARTNER_USER_SECRET }} EXPENSIFY_PARTNER_PASSWORD_EMAIL: ${{ secrets.EXPENSIFY_PARTNER_PASSWORD_EMAIL }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }} PATH_ENV_FILE: tests/e2e/.env.e2e buildDelta: @@ -137,6 +138,7 @@ jobs: EXPENSIFY_PARTNER_USER_ID: ${{ secrets.EXPENSIFY_PARTNER_USER_ID }} EXPENSIFY_PARTNER_USER_SECRET: ${{ secrets.EXPENSIFY_PARTNER_USER_SECRET }} EXPENSIFY_PARTNER_PASSWORD_EMAIL: ${{ secrets.EXPENSIFY_PARTNER_PASSWORD_EMAIL }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }} PATH_ENV_FILE: tests/e2e/.env.e2edelta runTestsInAWS: @@ -239,7 +241,7 @@ jobs: channel: '#e2e-announce', attachments: [{ color: 'danger', - text: `💥 ${process.env.AS_REPO} E2E Test run failed failed on workflow 💥`, + text: `💥 ${process.env.AS_REPO} E2E Test run failed on workflow 💥`, }] } env: From ed21ec4ed7a3e1286796d0eea0dd301d6d37f580 Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Thu, 1 Aug 2024 14:06:55 +0200 Subject: [PATCH 2/2] fix: change emoji to distinguish different error messages --- .github/actions/composite/buildAndroidE2EAPK/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/composite/buildAndroidE2EAPK/action.yml b/.github/actions/composite/buildAndroidE2EAPK/action.yml index 424f6150f01c..25fafcb7be7f 100644 --- a/.github/actions/composite/buildAndroidE2EAPK/action.yml +++ b/.github/actions/composite/buildAndroidE2EAPK/action.yml @@ -88,7 +88,7 @@ runs: channel: '#e2e-announce', attachments: [{ color: 'danger', - text: `💥 ${process.env.AS_REPO} E2E APK build run failed on workflow 💥`, + text: `🚧 ${process.env.AS_REPO} E2E APK build run failed on workflow 🚧`, }] } env: