From a32fa95627b8a5a9a093c8e05e79dd2facf9f8a9 Mon Sep 17 00:00:00 2001 From: Pujan Date: Wed, 19 Jul 2023 23:03:01 +0530 Subject: [PATCH 1/2] added shouldEnableMaxHeight to ScreenWrapper for ios safari --- src/pages/settings/Profile/Contacts/NewContactMethodPage.js | 1 + src/pages/settings/Profile/DisplayNamePage.js | 5 ++++- src/pages/settings/Profile/PersonalDetails/AddressPage.js | 5 ++++- src/pages/settings/Profile/PersonalDetails/LegalNamePage.js | 5 ++++- src/pages/settings/Security/CloseAccountPage.js | 5 ++++- src/pages/tasks/NewTaskDescriptionPage.js | 1 + src/pages/tasks/NewTaskDetailsPage.js | 1 + src/pages/tasks/NewTaskTitlePage.js | 1 + src/pages/tasks/TaskDescriptionPage.js | 1 + src/pages/tasks/TaskTitlePage.js | 1 + src/pages/workspace/WorkspacePageWithSections.js | 1 + 11 files changed, 23 insertions(+), 4 deletions(-) diff --git a/src/pages/settings/Profile/Contacts/NewContactMethodPage.js b/src/pages/settings/Profile/Contacts/NewContactMethodPage.js index 8a85c6857661..d554f7665769 100644 --- a/src/pages/settings/Profile/Contacts/NewContactMethodPage.js +++ b/src/pages/settings/Profile/Contacts/NewContactMethodPage.js @@ -125,6 +125,7 @@ function NewContactMethodPage(props) { loginInputRef.current.focus(); }} includeSafeAreaPaddingBottom={false} + shouldEnableMaxHeight > + Navigation.goBack(ROUTES.SETTINGS_PROFILE)} diff --git a/src/pages/settings/Profile/PersonalDetails/AddressPage.js b/src/pages/settings/Profile/PersonalDetails/AddressPage.js index 121065ae4097..aa132bf519df 100644 --- a/src/pages/settings/Profile/PersonalDetails/AddressPage.js +++ b/src/pages/settings/Profile/PersonalDetails/AddressPage.js @@ -118,7 +118,10 @@ function AddressPage(props) { }, []); return ( - + + Navigation.goBack(ROUTES.SETTINGS_PERSONAL_DETAILS)} diff --git a/src/pages/settings/Security/CloseAccountPage.js b/src/pages/settings/Security/CloseAccountPage.js index 652748af2a8f..efccbc11e09a 100644 --- a/src/pages/settings/Security/CloseAccountPage.js +++ b/src/pages/settings/Security/CloseAccountPage.js @@ -75,7 +75,10 @@ function CloseAccountPage(props) { const userEmailOrPhone = props.formatPhoneNumber(props.session.email); return ( - + Navigation.goBack(ROUTES.SETTINGS_SECURITY)} diff --git a/src/pages/tasks/NewTaskDescriptionPage.js b/src/pages/tasks/NewTaskDescriptionPage.js index b7e016f56790..a162c2c2c549 100644 --- a/src/pages/tasks/NewTaskDescriptionPage.js +++ b/src/pages/tasks/NewTaskDescriptionPage.js @@ -55,6 +55,7 @@ function NewTaskDescriptionPage(props) { focusAndUpdateMultilineInputRange(inputRef.current)} + shouldEnableMaxHeight > inputRef.current && inputRef.current.focus()} includeSafeAreaPaddingBottom={false} + shouldEnableMaxHeight > focusAndUpdateMultilineInputRange(inputRef.current)} + shouldEnableMaxHeight >
focusAndUpdateMultilineInputRange(inputRef.current)} + shouldEnableMaxHeight > Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)} From 7a125af07e1d2b6cb2ebeddbf21a4f4617414b2d Mon Sep 17 00:00:00 2001 From: Pujan Date: Thu, 20 Jul 2023 22:16:27 +0530 Subject: [PATCH 2/2] reverted shouldEnableMaxHeight for closeAccount and Address page --- src/pages/settings/Profile/PersonalDetails/AddressPage.js | 5 +---- src/pages/settings/Security/CloseAccountPage.js | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/pages/settings/Profile/PersonalDetails/AddressPage.js b/src/pages/settings/Profile/PersonalDetails/AddressPage.js index aa132bf519df..121065ae4097 100644 --- a/src/pages/settings/Profile/PersonalDetails/AddressPage.js +++ b/src/pages/settings/Profile/PersonalDetails/AddressPage.js @@ -118,10 +118,7 @@ function AddressPage(props) { }, []); return ( - + + Navigation.goBack(ROUTES.SETTINGS_SECURITY)}