From a8ef3ddb9d4c4a93ba366b2a8e36318412ccd1f4 Mon Sep 17 00:00:00 2001 From: Hezekiel Tamire Date: Wed, 5 Jul 2023 15:20:07 +0300 Subject: [PATCH 1/2] prevent magic input from losing function when clicking on Didnt receive code option --- src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js b/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js index 845b6f2ce698..f20d61cbcb49 100755 --- a/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js +++ b/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js @@ -91,7 +91,7 @@ function BaseValidateCodeForm(props) { const hasError = Boolean(props.account) && !_.isEmpty(props.account.errors); useEffect(() => { - if (!(inputValidateCodeRef.current && ((hasError && props.session.autoAuthState === CONST.AUTO_AUTH_STATE.FAILED) || props.account.isLoading))) { + if (!(inputValidateCodeRef.current && hasError && (props.session.autoAuthState === CONST.AUTO_AUTH_STATE.FAILED || props.account.isLoading))) { return; } inputValidateCodeRef.current.blur(); @@ -286,7 +286,7 @@ function BaseValidateCodeForm(props) { disabled={props.network.isOffline} hoverDimmingValue={1} pressDimmingValue={0.2} - accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON} + accessibilityRole="button" accessibilityLabel={props.translate('validateCodeForm.magicCodeNotReceived')} > From c51349b124f93a42e237ac5403ee900030fcff34 Mon Sep 17 00:00:00 2001 From: Hezekiel Tamire Date: Wed, 5 Jul 2023 15:25:02 +0300 Subject: [PATCH 2/2] added hasError check --- src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js b/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js index f20d61cbcb49..d5e0f73d303f 100755 --- a/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js +++ b/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js @@ -286,7 +286,7 @@ function BaseValidateCodeForm(props) { disabled={props.network.isOffline} hoverDimmingValue={1} pressDimmingValue={0.2} - accessibilityRole="button" + accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON} accessibilityLabel={props.translate('validateCodeForm.magicCodeNotReceived')} >