From 18810b6948ed0ea98cf9250b5b99dd3c4b6883fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ska=C5=82ka?= Date: Tue, 6 Jun 2023 16:17:50 +0200 Subject: [PATCH 1/2] migrated ImageView to PressableWithoutFeedback --- src/components/ImageView/index.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/components/ImageView/index.js b/src/components/ImageView/index.js index e070dddd2770..98b00251f666 100644 --- a/src/components/ImageView/index.js +++ b/src/components/ImageView/index.js @@ -1,12 +1,13 @@ import React, {PureComponent} from 'react'; import PropTypes from 'prop-types'; -import {View, Pressable} from 'react-native'; +import {View} from 'react-native'; import Image from '../Image'; import styles from '../../styles/styles'; import * as StyleUtils from '../../styles/StyleUtils'; import * as DeviceCapabilities from '../../libs/DeviceCapabilities'; import withWindowDimensions, {windowDimensionsPropTypes} from '../withWindowDimensions'; import FullscreenLoadingIndicator from '../FullscreenLoadingIndicator'; +import PressableWithoutFeedback from '../Pressable/PressableWithoutFeedback'; const propTypes = { /** Whether source url requires authentication */ @@ -266,7 +267,8 @@ class ImageView extends PureComponent { onLayout={this.onContainerLayoutChanged} style={[styles.imageViewContainer, styles.overflowAuto, styles.pRelative]} > - - + {this.state.isLoading && } From cbb88e4b3409ad0935bafaaf8e310c4487ced513 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ska=C5=82ka?= Date: Tue, 13 Jun 2023 09:52:35 +0200 Subject: [PATCH 2/2] added accessibility props --- src/components/AttachmentView.js | 1 + src/components/ImageView/index.js | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/components/AttachmentView.js b/src/components/AttachmentView.js index cf9814149322..2d6bc3536c53 100755 --- a/src/components/AttachmentView.js +++ b/src/components/AttachmentView.js @@ -113,6 +113,7 @@ const AttachmentView = (props) => { ); diff --git a/src/components/ImageView/index.js b/src/components/ImageView/index.js index 98b00251f666..2bffa7787088 100644 --- a/src/components/ImageView/index.js +++ b/src/components/ImageView/index.js @@ -19,6 +19,10 @@ const propTypes = { /** URL to full-sized image */ url: PropTypes.string.isRequired, + + /** image file name */ + fileName: PropTypes.string.isRequired, + ...windowDimensionsPropTypes, }; @@ -268,7 +272,6 @@ class ImageView extends PureComponent { style={[styles.imageViewContainer, styles.overflowAuto, styles.pRelative]} >