From 1e91f93eeac7e85557b2d01894c0d08763d6590b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ska=C5=82ka?= Date: Fri, 26 May 2023 14:00:32 +0200 Subject: [PATCH 1/2] migrate ModalHeader to PressableWithFeedback --- src/pages/iou/ModalHeader.js | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/pages/iou/ModalHeader.js b/src/pages/iou/ModalHeader.js index dd5b3fdadf54..30556dae86c1 100644 --- a/src/pages/iou/ModalHeader.js +++ b/src/pages/iou/ModalHeader.js @@ -1,5 +1,5 @@ import React from 'react'; -import {View, TouchableOpacity} from 'react-native'; +import {View} from 'react-native'; import PropTypes from 'prop-types'; import styles from '../../styles/styles'; import Icon from '../../components/Icon'; @@ -8,6 +8,7 @@ import withLocalize, {withLocalizePropTypes} from '../../components/withLocalize import * as Expensicons from '../../components/Icon/Expensicons'; import Tooltip from '../../components/Tooltip'; import Navigation from '../../libs/Navigation/Navigation'; +import PressableWithFeedback from '../../components/Pressable/PressableWithFeedback'; const propTypes = { /** Title of the header */ @@ -32,25 +33,33 @@ const ModalHeader = (props) => ( {props.shouldShowBackButton && ( - - + )}
- Navigation.dismissModal()} style={[styles.touchableButtonImage]} accessibilityRole="button" accessibilityLabel={props.translate('common.close')} + // disable hover dim for switch + hoverDimmingValue={1} + pressDimmingValue={0.2} > - + From 83dcc79bc527d757c02f891008098594b3099151 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ska=C5=82ka?= Date: Mon, 29 May 2023 11:42:46 +0200 Subject: [PATCH 2/2] fixed comments --- src/pages/iou/ModalHeader.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/iou/ModalHeader.js b/src/pages/iou/ModalHeader.js index 30556dae86c1..82b7aff7df83 100644 --- a/src/pages/iou/ModalHeader.js +++ b/src/pages/iou/ModalHeader.js @@ -38,7 +38,7 @@ const ModalHeader = (props) => ( style={[styles.touchableButtonImage]} accessibilityRole="button" accessibilityLabel={props.translate('common.back')} - // disable hover dim for switch + // disable hover dimming hoverDimmingValue={1} pressDimmingValue={0.2} > @@ -54,7 +54,7 @@ const ModalHeader = (props) => ( style={[styles.touchableButtonImage]} accessibilityRole="button" accessibilityLabel={props.translate('common.close')} - // disable hover dim for switch + // disable hover dimming hoverDimmingValue={1} pressDimmingValue={0.2} >