From c57cb6f24a02d9d6eb14318e4863e6c07b13216e Mon Sep 17 00:00:00 2001 From: daraksha Date: Tue, 23 May 2023 14:03:03 +0530 Subject: [PATCH 1/3] use default cursor when interactive is false --- src/components/MenuItem.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/MenuItem.js b/src/components/MenuItem.js index 5d893424e132..7de31d62e4c7 100644 --- a/src/components/MenuItem.js +++ b/src/components/MenuItem.js @@ -106,6 +106,7 @@ const MenuItem = (props) => { onSecondaryInteraction={props.onSecondaryInteraction} style={({hovered, pressed}) => [ props.style, + !props.interactive && styles.cursorDefault, StyleUtils.getButtonBackgroundColorStyle(getButtonState(props.focused || hovered, pressed, props.success, props.disabled, props.interactive), true), ...(_.isArray(props.wrapperStyle) ? props.wrapperStyle : [props.wrapperStyle]), ]} From 71c57d0f8441119e0fd4ca5eda72764b6195ea9a Mon Sep 17 00:00:00 2001 From: daraksha Date: Tue, 23 May 2023 14:03:27 +0530 Subject: [PATCH 2/3] remove disabled as it is read-only --- src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js b/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js index 4b7459ea7cfa..2b41cd79e95d 100644 --- a/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js +++ b/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js @@ -440,7 +440,6 @@ class BasePaymentsPage extends React.Component { icon={this.state.formattedSelectedPaymentMethod.icon} description={this.state.formattedSelectedPaymentMethod.description} wrapperStyle={[styles.pv0, styles.ph0, styles.mb4]} - disabled interactive={false} /> )} From c57ba6f344e36a62245e1cbb0fd705b9d2210cf8 Mon Sep 17 00:00:00 2001 From: daraksha Date: Tue, 23 May 2023 15:05:24 +0530 Subject: [PATCH 3/3] return if interactive is false --- src/components/MenuItem.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/MenuItem.js b/src/components/MenuItem.js index 7de31d62e4c7..b8f7d3ab8d46 100644 --- a/src/components/MenuItem.js +++ b/src/components/MenuItem.js @@ -91,7 +91,7 @@ const MenuItem = (props) => { return ( { - if (props.disabled) { + if (props.disabled || !props.interactive) { return; }