From 9289fbdad24815bae4e62c8626e905a7512c5a0d Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Tue, 7 Mar 2023 16:02:44 -0500 Subject: [PATCH 1/2] use pr number variable --- .github/workflows/testBuild.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/testBuild.yml b/.github/workflows/testBuild.yml index ef37d1266930..612a23428bec 100644 --- a/.github/workflows/testBuild.yml +++ b/.github/workflows/testBuild.yml @@ -290,6 +290,6 @@ jobs: IOS: ${{ needs.iOS.result }} WEB: ${{ needs.web.result }} ANDROID_LINK: ${{fromJson(steps.get_android_path.outputs.android_paths).html_path}} - DESKTOP_LINK: "https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/$PULL_REQUEST_NUMBER/NewExpensify.dmg" + DESKTOP_LINK: "https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/$PR_NUMBER/NewExpensify.dmg" IOS_LINK: ${{ fromJson(steps.get_ios_path.outputs.ios_paths).html_path }} - WEB_LINK: "https://$PULL_REQUEST_NUMBER.pr-testing.expensify.com" + WEB_LINK: "https://$PR_NUMBER.pr-testing.expensify.com" From 83e85f3a920a9221d74648dc6a0c26506206258d Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Tue, 7 Mar 2023 16:25:02 -0500 Subject: [PATCH 2/2] fix link syntax --- .github/workflows/testBuild.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/testBuild.yml b/.github/workflows/testBuild.yml index 612a23428bec..6b068c9f6f8e 100644 --- a/.github/workflows/testBuild.yml +++ b/.github/workflows/testBuild.yml @@ -290,6 +290,6 @@ jobs: IOS: ${{ needs.iOS.result }} WEB: ${{ needs.web.result }} ANDROID_LINK: ${{fromJson(steps.get_android_path.outputs.android_paths).html_path}} - DESKTOP_LINK: "https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/$PR_NUMBER/NewExpensify.dmg" + DESKTOP_LINK: https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/${{ env.PULL_REQUEST_NUMBER }}/NewExpensify.dmg IOS_LINK: ${{ fromJson(steps.get_ios_path.outputs.ios_paths).html_path }} - WEB_LINK: "https://$PR_NUMBER.pr-testing.expensify.com" + WEB_LINK: https://${{ env.PULL_REQUEST_NUMBER }}.pr-testing.expensify.com