From 15ea4cc832f7ceb9d1ee9bb9b3dc1b557823eddf Mon Sep 17 00:00:00 2001 From: puneet Date: Wed, 19 Oct 2022 19:34:30 -0700 Subject: [PATCH 1/4] add character limit error --- src/pages/home/report/ReportActionItemMessageEdit.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pages/home/report/ReportActionItemMessageEdit.js b/src/pages/home/report/ReportActionItemMessageEdit.js index 49a442e9b031..bb2cb4e826b9 100644 --- a/src/pages/home/report/ReportActionItemMessageEdit.js +++ b/src/pages/home/report/ReportActionItemMessageEdit.js @@ -19,6 +19,7 @@ import EmojiPickerButton from '../../../components/EmojiPicker/EmojiPickerButton import * as ReportActionContextMenu from './ContextMenu/ReportActionContextMenu'; import VirtualKeyboard from '../../../libs/VirtualKeyboard'; import reportPropTypes from '../../reportPropTypes'; +import ExceededCommentLength from '../../../components/ExceededCommentLength'; const propTypes = { /** All the data of the action */ @@ -240,6 +241,7 @@ class ReportActionItemMessageEdit extends React.Component { onPress={this.publishDraft} text={this.props.translate('common.saveChanges')} /> + ); From 4d5ab690c8d3b7b1919c23a9482788f5ab5b8346 Mon Sep 17 00:00:00 2001 From: puneet Date: Wed, 19 Oct 2022 19:44:02 -0700 Subject: [PATCH 2/4] disable saving the comment when character limit has exceeded --- src/pages/home/report/ReportActionItemMessageEdit.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pages/home/report/ReportActionItemMessageEdit.js b/src/pages/home/report/ReportActionItemMessageEdit.js index bb2cb4e826b9..80b0e1336a68 100644 --- a/src/pages/home/report/ReportActionItemMessageEdit.js +++ b/src/pages/home/report/ReportActionItemMessageEdit.js @@ -20,6 +20,7 @@ import * as ReportActionContextMenu from './ContextMenu/ReportActionContextMenu' import VirtualKeyboard from '../../../libs/VirtualKeyboard'; import reportPropTypes from '../../reportPropTypes'; import ExceededCommentLength from '../../../components/ExceededCommentLength'; +import CONST from '../../../CONST'; const propTypes = { /** All the data of the action */ @@ -179,6 +180,9 @@ class ReportActionItemMessageEdit extends React.Component { } if (e.key === 'Enter' && !e.shiftKey) { e.preventDefault(); + if (this.state.draft.length > CONST.MAX_COMMENT_LENGTH) { + return; + } this.publishDraft(); } else if (e.key === 'Escape') { e.preventDefault(); @@ -187,6 +191,7 @@ class ReportActionItemMessageEdit extends React.Component { } render() { + const hasExceededMaxCommentLength = this.state.draft.length > CONST.MAX_COMMENT_LENGTH; return ( @@ -236,6 +241,7 @@ class ReportActionItemMessageEdit extends React.Component {