From 6b26bc15660c22ff1fa83166fa9b49acc4c7b137 Mon Sep 17 00:00:00 2001 From: aimane-chnaif Date: Sat, 15 Oct 2022 01:47:53 +1000 Subject: [PATCH 1/3] fix crash after login whiile trying to open profile details URL --- src/pages/DetailsPage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/DetailsPage.js b/src/pages/DetailsPage.js index 24cb7370a48a..10ce6e6c851d 100755 --- a/src/pages/DetailsPage.js +++ b/src/pages/DetailsPage.js @@ -77,7 +77,7 @@ class DetailsPage extends React.PureComponent { } render() { - const details = this.props.personalDetails[lodashGet(this.props.route.params, 'login')]; + const details = lodashGet(this.props.personalDetails, lodashGet(this.props.route.params, 'login')); if (!details) { // Personal details have not loaded yet return ; From 787e4f167cb48ce25ebba5a4a67104fdc4a4a972 Mon Sep 17 00:00:00 2001 From: aimane-chnaif Date: Tue, 18 Oct 2022 16:44:41 +1000 Subject: [PATCH 2/3] set personalDetails optional on DetailsPage --- src/pages/DetailsPage.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/pages/DetailsPage.js b/src/pages/DetailsPage.js index 10ce6e6c851d..a6a27e533359 100755 --- a/src/pages/DetailsPage.js +++ b/src/pages/DetailsPage.js @@ -40,7 +40,7 @@ const propTypes = { /* Onyx Props */ /** The personal details of the person who is logged in */ - personalDetails: personalDetailsPropType.isRequired, + personalDetails: personalDetailsPropType, /** Route params */ route: matchType.isRequired, @@ -48,6 +48,11 @@ const propTypes = { ...withLocalizePropTypes, }; +const defaultProps = { + // The case when open other profile deep link before login + personalDetails: {}, +}; + /** * Gets the phone number to display for SMS logins * @@ -202,6 +207,7 @@ class DetailsPage extends React.PureComponent { } DetailsPage.propTypes = propTypes; +DetailsPage.defaultProps = defaultProps; export default compose( withLocalize, From e1f1c1400678be0d56a96487e7527e758f7b2a4c Mon Sep 17 00:00:00 2001 From: aimane-chnaif <96077027+aimane-chnaif@users.noreply.github.com> Date: Thu, 20 Oct 2022 04:25:31 -0600 Subject: [PATCH 3/3] Update comment Co-authored-by: Alex Beaman --- src/pages/DetailsPage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/DetailsPage.js b/src/pages/DetailsPage.js index a6a27e533359..dd94fca3f6ee 100755 --- a/src/pages/DetailsPage.js +++ b/src/pages/DetailsPage.js @@ -49,7 +49,7 @@ const propTypes = { }; const defaultProps = { - // The case when open other profile deep link before login + // When opening someone else's profile (via deep link) before login, this is empty personalDetails: {}, };