diff --git a/src/Shared/Extensions/ProjectExtension.cs b/src/Shared/Extensions/ProjectExtension.cs index ca77f31..873e6b5 100644 --- a/src/Shared/Extensions/ProjectExtension.cs +++ b/src/Shared/Extensions/ProjectExtension.cs @@ -12,7 +12,6 @@ namespace SqlProjectsPowerTools internal static class ProjectExtension { private const string SqlServerRulesPackageId = "ErikEJ.DacFX.SqlServer.Rules"; - private const string TSqlSmellRulesPackageId = "ErikEJ.DacFX.TSQLSmellSCA"; private const string Indent = "\n "; private const string EndElementIndent = "\n "; private const string NewLine = "\n"; @@ -200,8 +199,7 @@ public static async Task HasRulesPackagesAsync(this Project project) return false; } - return await project.IsInstalledAsync(SqlServerRulesPackageId) - || await project.IsInstalledAsync(TSqlSmellRulesPackageId); + return await project.IsInstalledAsync(SqlServerRulesPackageId); } public static async Task AddRulesPackagesAsync(this Project project) @@ -226,7 +224,7 @@ public static async Task AddRulesPackagesAsync(this Project project) return "Unable to locate the selected project file."; } - foreach (var packageId in new[] { SqlServerRulesPackageId, TSqlSmellRulesPackageId }) + foreach (var packageId in new[] { SqlServerRulesPackageId }) { if (await project.IsInstalledAsync(packageId)) { diff --git a/src/Shared/ViewModels/RuleViewModel.cs b/src/Shared/ViewModels/RuleViewModel.cs index 8f9fcc7..f84c8da 100644 --- a/src/Shared/ViewModels/RuleViewModel.cs +++ b/src/Shared/ViewModels/RuleViewModel.cs @@ -136,11 +136,6 @@ private static string GetHelpLink(string id, string category) return $"https://github.com/ErikEJ/SqlServer.Rules/blob/master/docs/{categoryName}/{ruleId}.md"; } - if (id.StartsWith("Smells.", StringComparison.OrdinalIgnoreCase)) - { - return $"https://github.com/ErikEJ/SqlServer.Rules/blob/master/docs/CodeSmells/{ruleId}.md"; - } - return string.Empty; } diff --git a/src/SsmsVsix/Dialogs/ManageRulesDialog.xaml b/src/SsmsVsix/Dialogs/ManageRulesDialog.xaml index 2bdcc05..9add3ce 100644 --- a/src/SsmsVsix/Dialogs/ManageRulesDialog.xaml +++ b/src/SsmsVsix/Dialogs/ManageRulesDialog.xaml @@ -48,7 +48,7 @@ Margin="0,4,0,8" VerticalAlignment="Center"> + Text="Install community code analyzers (ErikEJ.DacFX.SqlServer.Rules)" /> @@ -67,7 +67,7 @@ Visibility="{Binding ShowNoRulesPackageWarning, Converter={StaticResource BoolToVisibility}}"> + Text="No code analysis rules packages are referenced in this project. Consider adding NuGet packages such as 'ErikEJ.DacFX.SqlServer.Rules' to get additional rules." /> diff --git a/src/SsmsVsix/Linter/Linting/AnalyzerUtilities.cs b/src/SsmsVsix/Linter/Linting/AnalyzerUtilities.cs index a5b79dd..a5fb9e1 100644 --- a/src/SsmsVsix/Linter/Linting/AnalyzerUtilities.cs +++ b/src/SsmsVsix/Linter/Linting/AnalyzerUtilities.cs @@ -246,7 +246,6 @@ public static (string Filename, int Line, int Column, string RuleId, string Desc } // C:\Users\ErikEjlskovJensen(De\AppData\Local\Temp\tsqlanalyzerscratch.sql(23,1): SqlServer.Rules.SRN0007 : Index 'IFK_EmployeeReportsTo' does not follow the company naming standard. Please use a format that starts with IX_Employee*. (https://github.com/ErikEJ/SqlServer.Rules/blob/master/docs/Naming/SRN0007.md) - // C:\Users\ErikEjlskovJensen(De\AppData\Local\Temp\tsqlanalyzerscratch.sql(6,9): Smells.SML005 : Avoid use of 'Select *'. (https://github.com/ErikEJ/SqlServer.Rules/blob/master/docs/CodeSmells/SML005.md) var fileAndPosition = parts[0].Trim(); var lineColumnStart = fileAndPosition.LastIndexOf('('); var lineColumnEnd = fileAndPosition.LastIndexOf(')'); diff --git a/src/Vsix/Dialogs/ManageRulesDialog.xaml b/src/Vsix/Dialogs/ManageRulesDialog.xaml index 858cd00..d67e759 100644 --- a/src/Vsix/Dialogs/ManageRulesDialog.xaml +++ b/src/Vsix/Dialogs/ManageRulesDialog.xaml @@ -47,9 +47,9 @@ IsEnabled="{Binding CanInstallRulesPackages}" Margin="0,4,0,8" VerticalAlignment="Center" - ToolTip="Install community code analyzers (ErikEJ.DacFX.SqlServer.Rules and ErikEJ.DacFX.TSQLSmellSCA)"> + ToolTip="Install community code analyzers (ErikEJ.DacFX.SqlServer.Rules)"> + Text="Install community code analyzers (ErikEJ.DacFX.SqlServer.Rules)" /> @@ -68,7 +68,7 @@ Visibility="{Binding ShowNoRulesPackageWarning, Converter={StaticResource BoolToVisibility}}"> + Text="No code analysis rules packages are referenced in this project. Consider adding NuGet packages such as 'ErikEJ.DacFX.SqlServer.Rules' to get additional rules." />