Prepare 23.3.1rc1 #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

delta1 merged 41 commits into ElementsProject:elements-23.x from psgreco:elem-23.3.1-rc1

Jul 21, 2025

.cirrus.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -58,7 +58,8 @@ macos_native_task_template: &MACOS_NATIVE_TASK_TEMPLATE @@
       check_clang_script:
         - clang --version
       brew_install_script:
-        - brew install boost libevent qt@5 miniupnpc libnatpmp ccache zeromq qrencode libtool automake gnu-getopt
+        - brew install boost@1.85 libevent qt@5 miniupnpc libnatpmp ccache zeromq qrencode libtool automake gnu-getopt
+        - brew link --force --overwrite boost@1.85
       << : *MAIN_TEMPLATE
     compute_credits_template: &CREDITS_TEMPLATE
@@ Expand All / @@ -80,8 +81,7 @@ task: @@
       env:
         << : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV
-    task:
-      name: "Win64 native [msvc]"
+    win64_native_common: &win64_native_common
       << : *FILTER_TEMPLATE
       windows_container:
         cpu: 4
@@ Expand Down Expand Up / @@ -159,6 +159,22 @@ task: @@
         - cd %CIRRUS_WORKING_DIR%
         - python build_msvc\msvc-autogen.py
         - msbuild build_msvc\bitcoin.sln -property:Configuration=Release -maxCpuCount -verbosity:minimal -noLogo
+    task:
+      name: "Win64 native [msvc] (Short running functional tests)"
+      <<: *win64_native_common
+      functional_tests_script:
+        # Increase the dynamic port range to the maximum allowed value to mitigate "OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted".
+        # See: https://docs.microsoft.com/en-us/biztalk/technical-guides/settings-that-can-be-modified-to-improve-network-performance
+        - netsh int ipv4 set dynamicport tcp start=1025 num=64511
+        - netsh int ipv6 set dynamicport tcp start=1025 num=64511
+        # Heavier tests are moved to a secondary task
+        # Exclude feature_dbcrash and feature_fee_estimation, failing https://github.com/ElementsProject/elements/pull/1298
+        - python test\functional\test_runner.py --nocleanup --ci --quiet --combinedlogslen=4000 --jobs=4 --timeout-factor=8 --extended --exclude wallet_avoidreuse,feature_trim_headers,feature_dbcrash,feature_fee_estimation
+    task:
+      name: "Win64 native [msvc] (Long running functional tests + unit tests)"
+      <<: *win64_native_common
       unit_tests_script:
         - src\test_elements.exe -l test_suite
         - src\bench_elements.exe > NUL
@@ Expand All / @@ -169,10 +185,9 @@ task: @@
         # See: https://docs.microsoft.com/en-us/biztalk/technical-guides/settings-that-can-be-modified-to-improve-network-performance
         - netsh int ipv4 set dynamicport tcp start=1025 num=64511
         - netsh int ipv6 set dynamicport tcp start=1025 num=64511
-        # Exclude feature_dbcrash for now due to timeout
-        # Exclude also wallet_avoidreuse due to timeout
-        # Ignore failures for now, need to investigate but we really don't use native win64 builds
-        - python test\functional\test_runner.py --nocleanup --ci --quiet --combinedlogslen=4000 --jobs=4 --timeout-factor=8 --extended --exclude feature_dbcrash,wallet_avoidreuse || true
+        # Execute tests excluded from the main task
+        # Ignore failures for now until https://github.com/ElementsProject/elements/pull/1298 is merged
+        - python test\functional\test_runner.py --nocleanup --ci --quiet --combinedlogslen=4000 --jobs=4 --timeout-factor=8 wallet_avoidreuse feature_trim_headers feature_dbcrash feature_fee_estimation || true
     task:
       name: 'ARM [unit tests, no functional tests] [bullseye]'
@@ Expand Down @@

README.md

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,7 +1,7 @@
  
    Elements Project blockchain platform

    ====================================

    [![Build Status](https://travis-ci.org/ElementsProject/elements.svg?branch=master)](https://travis-ci.org/ElementsProject/elements)

    [![Release](https://img.shields.io/github/v/release/ElementsProject/elements?label=latest%20release&link=https%3A%2F%2Fgithub.com%2FElementsProject%2Felements%2Freleases%2Flatest)](https://github.com/ElementsProject/elements/releases)

    https://elementsproject.org

ci/test/04_install.sh

-Original file line number
+Diff line change
@@ Expand Up / @@ -11,7 +11,7 @@ if [[ $QEMU_USER_CMD == qemu-s390* ]]; then @@
     fi
     if [ "$CI_OS_NAME" == "macos" ]; then
-      sudo -H pip3 install --upgrade pip
+      sudo -H pip3 install --upgrade --break-system-packages pip
       # shellcheck disable=SC2086
       IN_GETOPT_BIN="$(brew --prefix gnu-getopt)/bin/getopt" ${CI_RETRY_EXE} pip3 install --user $PIP_PACKAGES
     fi
@@ Expand Down @@

configure.ac

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,8 +1,8 @@
  
    AC_PREREQ([2.69])

    define(_CLIENT_VERSION_MAJOR, 23)

    define(_CLIENT_VERSION_MINOR, 3)

    define(_CLIENT_VERSION_BUILD, 0)

    define(_CLIENT_VERSION_RC, 0)

    define(_CLIENT_VERSION_BUILD, 1)

    define(_CLIENT_VERSION_RC, 1)

    define(_CLIENT_VERSION_IS_RELEASE, true)

    define(_COPYRIGHT_YEAR, 2025)

    define(_COPYRIGHT_HOLDERS,[The %s developers])

    @@ -997,22 +997,6 @@ AC_CHECK_DECLS([bswap_16, bswap_32, bswap_64],,,
  
                     #include <byteswap.h>

                     #endif])

    AC_MSG_CHECKING([for __builtin_clzl])

    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ ]], [[

     (void) __builtin_clzl(0);

      ]])],

     [ AC_MSG_RESULT([yes]); have_clzl=yes; AC_DEFINE([HAVE_BUILTIN_CLZL], [1], [Define this symbol if you have __builtin_clzl])],

     [ AC_MSG_RESULT([no]); have_clzl=no;]

    )

    AC_MSG_CHECKING([for __builtin_clzll])

    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ ]], [[

      (void) __builtin_clzll(0);

      ]])],

     [ AC_MSG_RESULT([yes]); have_clzll=yes; AC_DEFINE([HAVE_BUILTIN_CLZLL], [1], [Define this symbol if you have __builtin_clzll])],

     [ AC_MSG_RESULT([no]); have_clzll=no;]

    )

    dnl Check for malloc_info (for memory statistics information in getmemoryinfo)

    AC_MSG_CHECKING([for getmemoryinfo])

    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <malloc.h>]],

    @@ -1836,7 +1820,6 @@ AM_CONDITIONAL([LIQUID], [test "$liquid_build" = "yes"])
  
    dnl for minisketch

    AM_CONDITIONAL([ENABLE_CLMUL], [test "$enable_clmul" = "yes"])

    AM_CONDITIONAL([HAVE_CLZ], [test "$have_clzl$have_clzll" = "yesyes"])

    AC_DEFINE([CLIENT_VERSION_MAJOR], [_CLIENT_VERSION_MAJOR], [Major version])

    AC_DEFINE([CLIENT_VERSION_MINOR], [_CLIENT_VERSION_MINOR], [Minor version])

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare 23.3.1rc1 #1475

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!