Run tests and lint via Github actions, consolidate test + non-test database containers

* Sets up Github Actions to run tests and linting on CI on every push
    * Only specifies to minor version for Ruby in CI, because of inconsistent availability on Ubuntu versions

* Updates linter rules to match current use, and fixes rubocop errors

* Regenerates bundle and rake binstubs

* Remove separate testdb container
    * Use existing db container for database. Differentiate connection information by env vars and a separate database name (action_center_test). Also removes test db migration logic from the Docker entrypoint, assuming that we will load the schema in. Updates the CI file accordingly.

* Relies on secrets.yml to make env vars available to application across environments
    * Deletes unneeded test-specific db configuration for env var; relies on environment to set instead
    * As much as possible, sets any config needed for test in the test env for secrets.yml
    * Deletes unused but confusing .env.test

* Copy rather than Add Dockerfile to allow for caching and reduce risk.
     * COPY will cache contents in order of declaration, which should help reduce the amount of time it takes to build the image. ADD copies everything anew each time without caching. Also, Docker warns that ADD could unintentionally introduce security risks, including downloading remote files and unpacking archives. https://www.docker.com/blog/docker-best-practices-understanding-the-differences-between-add-and-copy-instructions-in-dockerfiles/

* Remove unused travis.yml file

* Remove FactoryBot line that was initiating db connection on app startup
   * Was preventing us from creating a database with bin/rails db:create because it tried to connect to that same database before it was able to be created.

* Remove unmaintained congress images. Repo last updated ~10 years ago, so images were broken anyway.

* Move database env vars to database.yml. Try to reduce number of places where they appear.

---------

Co-authored-by: sylph <[email protected]>

Author: hartsick

.env.example

@@ -9,23 +9,12 @@ force_ssl=false
 time_zone="Pacific Time (US & Canada)"
 
 # Database configuration (required)
-db_adapter=postgresql
-db_database=postgres
 db_username=postgres
 db_password=mysecretpassword
 db_port=5432
 db_host=db
 DB_AUTO_MIGRATE=false # or true, depending on if you want to run migrations every time the container starts
 
-# Test database configuration
-test_db_password=mysecrettestpassword
-test_db_username=postgres
-test_db_database=postgres
-test_db_adapter=postgresql
-test_db_port=5432
-test_db_host=testdb
-TEST_DB_AUTO_MIGRATE=false
-
 # Social media (required)
 twitter_handle=example
 twitter_related="example examplelive"

.env.test

@@ -0,0 +1,18 @@
+name: "Setup"
+description: "Installs dependencies"
+runs:
+  using: "composite"
+  steps:
+    - name: Install Ruby and gems
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.3"
+        bundler-cache: true
+    - name: Install npm
+      uses: actions/setup-node@v4
+      with:
+        cache: npm
+        cache-dependency-path: 'package-lock.json'
+    - name: Install JS dependencies
+      shell: bash
+      run: npm ci

.github/actions/setup-action/action.yml

@@ -0,0 +1,54 @@
+# This workflow uses actions that are not certified by GitHub.  They are
+# provided by a third-party and are governed by separate terms of service,
+# privacy policy, and support documentation.
+#
+# This workflow will install a prebuilt Ruby version, install dependencies, and
+# run tests and linters.
+name: "Ruby on Rails CI"
+on: push
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    env:
+      RAILS_ENV: test
+
+      db_host: localhost
+      db_port: 5432
+      db_username: testuser
+      db_password: password
+    services:
+      postgres:
+        image: postgres:latest
+        ports:
+          - "5432:5432"
+        env:
+          POSTGRES_USER: testuser
+          POSTGRES_PASSWORD: password
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 500ms
+          --health-retries 15
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install dependencies
+        uses: ./.github/actions/setup-action
+      - name: Set up database schema
+        run: bin/rails db:create db:schema:load
+      - name: Run tests
+        run: bundle exec rspec
+
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install dependencies
+        uses: ./.github/actions/setup-action
+      - name: Generate binstubs
+        run: bundle binstubs rubocop
+      # - name: Security audit dependencies
+      #   run: bin/bundler-audit --update
+      # - name: Security audit application code
+      #   run: bin/brakeman -q -w2
+      - name: Lint Ruby files
+        run: bin/rubocop --parallel

.github/workflows/rails_ci.yml

@@ -24,25 +24,25 @@ RUN apt-get update && \
 COPY package.json package-lock.json ./
 RUN npm install
 
-ADD Gemfile* ./
+COPY Gemfile* ./
 
 RUN gem install bundler && bundle install
 
-ADD bin/ ./bin
-ADD config/ ./config
-ADD config.ru ./
-ADD Rakefile ./
-ADD db/ ./db
-ADD lib/ ./lib
-ADD public/ ./public
-ADD app/ ./app
-ADD features/ ./features
-ADD script/ ./script
-ADD spec/ ./spec
-ADD vendor/ ./vendor
-ADD docker/ ./docker
-ADD .rubocop.yml ./.rubocop.yml
-ADD .sass-lint.yml ./.sass-lint.yml
+COPY bin/ ./bin
+COPY config/ ./config
+COPY config.ru ./
+COPY Rakefile ./
+COPY db/ ./db
+COPY lib/ ./lib
+COPY public/ ./public
+COPY app/ ./app
+COPY features/ ./features
+COPY script/ ./script
+COPY spec/ ./spec
+COPY vendor/ ./vendor
+COPY docker/ ./docker
+COPY .rubocop.yml ./.rubocop.yml
+COPY .sass-lint.yml ./.sass-lint.yml
 
 RUN usermod -u 1000 www-data
 

.travis.yml

@@ -26,7 +26,6 @@ gem "uglifier", ">= 1.3.0"        # compressor for JavaScript assets
 
 source "https://rails-assets.org" do
   gem "rails-assets-chartjs", "~> 2"
-  gem "rails-assets-congress-images-102x125"
   gem "rails-assets-EpicEditor", "~> 0"
   gem "rails-assets-html5shiv", "3.7.2"
   gem "rails-assets-ionicons", "~> 2"

Dockerfile

@@ -9,7 +9,6 @@ GEM
   specs:
     rails-assets-EpicEditor (0.2.3)
     rails-assets-chartjs (2.9.4)
-    rails-assets-congress-images-102x125 (0.1.2)
     rails-assets-html5shiv (3.7.2)
     rails-assets-ionicons (2.0.1)
     rails-assets-jquery (2.1.3)
@@ -610,7 +609,6 @@ DEPENDENCIES
   rails (~> 7.0.0)
   rails-assets-EpicEditor (~> 0)!
   rails-assets-chartjs (~> 2)!
-  rails-assets-congress-images-102x125!
   rails-assets-html5shiv (= 3.7.2)!
   rails-assets-ionicons (~> 2)!
   rails-assets-jquery (= 2.1.3)!

Gemfile

@@ -3,12 +3,12 @@ module LoggedInvisibleCaptcha
 
   def on_spam(options = {})
     log_failure
-    super(options)
+    super
   end
 
   def on_timestamp_spam(options = {})
     log_failure
-    super(options)
+    super
   end
 
   def log_failure

Gemfile.lock

@@ -30,10 +30,6 @@ def email_friends_url(action_page)
     "mailto:?subject=#{u subject}&body=#{u message}"
   end
 
-  def rep_photo_src(bioguide_id)
-    asset_path "congress-images-102x125/i/#{bioguide_id}.jpg"
-  end
-
   def rep_tweet_link(rep)
     tweet_link("@#{rep.twitter_id}", class: "btn-tweet rep")
   end