Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

Architectural Decisions Records#62

Merged
gilesknap merged 10 commits into
mainfrom
dev
Jan 19, 2023
Merged

Architectural Decisions Records#62
gilesknap merged 10 commits into
mainfrom
dev

Conversation

@gilesknap
Copy link
Copy Markdown
Contributor

first draft of ADRs for python3-pip-skeleton.

  • Added ADRs 3 to 12
  • moved pre-commit explanation to ADR0008 on pre-commit and tox
  • moved using src explanation to ADR0004
  • moved docs structure explanation to ADR0003
  • moved ADRs to user explanations

remaining work is captured in this whiteboard

ADRS

@gilesknap gilesknap requested a review from coretl January 18, 2023 16:45
@gilesknap gilesknap marked this pull request as draft January 18, 2023 16:45
@gilesknap
Copy link
Copy Markdown
Contributor Author

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2023

Codecov Report

Merging #62 (ad056f9) into main (2072ea6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ad056f9 differs from pull request most recent head 613d09c. Consider uploading reports for the commit 613d09c to get more accurate results

@@            Coverage Diff            @@
##              main       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          138       135    -3     
=========================================
- Hits           138       135    -3     
Impacted Files Coverage Δ
src/python3_pip_skeleton/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gilesknap
Copy link
Copy Markdown
Contributor Author

@coretl while we are at this. Are we happy that the project is called python3-pip-skeleton-cli but the package is python3-pip-skeleton? It may be a little confusing and I did get asked about it this week. At the same time I like that the published package is called python3-pip-skeleton so not sure....

@gilesknap
Copy link
Copy Markdown
Contributor Author

@coretl I've added developer howto test container.

I think I'm done with the whiteboard points now. Let me know if you are happy to merge.

@gilesknap gilesknap marked this pull request as ready for review January 19, 2023 14:40
@gilesknap gilesknap merged commit 2932aa9 into main Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants