From ee8fb5939cd96bf93aa74cd5f5982402ab4b59ec Mon Sep 17 00:00:00 2001 From: Alexandre Rulleau Date: Wed, 15 Apr 2026 13:15:10 +0200 Subject: [PATCH] test(sidecar): re-enable test_ddog_sidecar_register_app on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit APMSP-2356: the tarpc refactor (#1742) introduced a PID handshake in SeqpacketConn::connect() — the blocking ReadFile waiting for the server's 4-byte PID acts as an implicit readiness barrier, eliminating the startup race that caused intermittent failures. --- datadog-sidecar-ffi/tests/sidecar.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/datadog-sidecar-ffi/tests/sidecar.rs b/datadog-sidecar-ffi/tests/sidecar.rs index fffabf9be0..311f9b73a0 100644 --- a/datadog-sidecar-ffi/tests/sidecar.rs +++ b/datadog-sidecar-ffi/tests/sidecar.rs @@ -68,10 +68,6 @@ fn test_ddog_sidecar_connection() { } #[test] -#[cfg_attr( - target_os = "windows", - ignore = "APMSP-2356 Investigate flakiness on Windows" -)] #[cfg_attr(miri, ignore)] fn test_ddog_sidecar_register_app() { set_sidecar_per_process();