fix: route plugin and build-logic deps through mavenRepositoryProxy#514
Conversation
The mavenRepositoryProxy Gradle property was only consulted in the root dependencyResolutionManagement, so plugin classpath resolution and the build-logic included build still hit gradlePluginPortal/mavenCentral directly. CI runners that restrict egress to the Depot mirror return 403 for those direct fetches, which broke ':build-logic:conventions: compileKotlin' on kotlin-build-tools-impl and kotlin-reflect. Wire the proxy into the root pluginManagement, the build-logic settings pluginManagement, and the conventions project repositories. The proxy is only added when the property is set, so local builds without it behave as before. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f734f4919
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
buildscript {} repositories are resolved independently of
dependencyResolutionManagement, so com.dipien:semantic-version-gradle-
plugin still hits mavenCentral/gradlePluginPortal directly and 403s
on egress-restricted runners. Add the proxy here too, ahead of the
public mirrors.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Good catch — pushed 5387d26e wiring Note: the |
The Depot magicmirror previously served a corrupted (POM-as-JAR) response for kotlin-compiler-embeddable-2.3.20.jar, which surfaced once Gradle 9.5 (PR #506) started pulling that artifact via the proxy added on this branch. The bad row has been cleared and re-ingestion now serves the correct ~57 MB JAR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CI Test ResultsRun: #25502656285 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-05-07 15:16:22 UTC |
Summary
mavenRepositoryProxyGradle property was only consulted in the rootdependencyResolutionManagement. Plugin classpath resolution and thebuild-logicincluded build still hitgradlePluginPortal()/mavenCentral()directly, so on CI runners that restrict egress to the Depot mirror those fetches fail with403 Forbidden.:build-logic:conventions:compileKotlinto fail downloadingkotlin-build-tools-impl-2.3.0.jarandkotlin-reflect-1.6.10.jar(sample failure: job 1664033372).build-logicresolution also flow through Depot when the property is set:pluginManagementinsettings.gradle.ktsbuild-logic/settings.gradlepluginManagement(the included build had none)repositories {}inbuild-logic/conventions/build.gradle.kts(the actual failing config:kotlinBuildToolsApiClasspath)The proxy is only added when the property is set, so local builds without
-PmavenRepositoryProxy=...continue to behave as before. CI exportsORG_GRADLE_PROJECT_mavenRepositoryProxyalready, so no.gitlab-ci.ymlchanges are needed.Test plan
:build-logic:conventions:compileKotlinand resolveskotlin-build-tools-impl/kotlin-reflectthroughdepot-read-api-java.us1.ddbuild.io(no 403s in the build log)../gradlew tasks(without the property set) still succeeds — proxy block is no-op when the property is absent.🤖 Generated with Claude Code