Skip to content

Conversation

@karannb
Copy link
Contributor

@karannb karannb commented Dec 26, 2024

  • Updated make_ensemble_predictions to also predict for classification tasks, I am not sure if we need the aleatoric standard deviation in the output DataFrame.
  • The check -
if "normalizer_dict" in checkpoint:

was incorrect, it would trigger even for classification tasks, because they have an empty normalizer dict for each task, but the attribute is present.

  • Performed a sanity check on denormalization by using my code and a version without this logic + denorming manually, they both produced the same results (switched to the state at 5afeb6a before doing this experiment).

@karannb
Copy link
Contributor Author

karannb commented Dec 26, 2024

Continuation of #91.

@karannb karannb changed the title Added predictions for classification task. Fixed the check for normlizer presence. Added predictions for classification task. Fixed the check for normalizer presence. Dec 26, 2024
@CompRhys CompRhys merged commit fe70c98 into CompRhys:main Jan 4, 2025
3 checks passed
@CompRhys
Copy link
Owner

CompRhys commented Jan 4, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants