Exclude dependencies from final jar#40
Merged
JorelAli merged 1 commit intoCommandAPI:masterfrom Jan 7, 2019
Merged
Conversation
Member
|
It doesn't necessarily reduce the jar size, since by default the dependency scope is "compile" and are not shaded into the jar, thus supplied at runtime. However, since this is good practice for a maven dependency and I'm always looking for ways to improve my knowledge of maven, I'll merge this. |
Contributor
Author
|
I'm actually shading the CommandAPI into my plugin jar and I noticed it was a little large after updating the version. I looked in the jar and found that bukkit along with brigadier was shaded into it. In this case with spigot, the bukkit and brigadier code is provided when the plugin is loaded so there's no need to include it |
Member
|
I see! Thanks for clarifying! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a non-breaking change and will reduce the jar size