You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .claude/skills/review-pipeline/SKILL.md
+3-19Lines changed: 3 additions & 19 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -136,25 +136,9 @@ Read the merge result from the report's `Merge Prep` section.
136
136
- If there are conflicts:
137
137
1. Inspect the conflicting files listed in the report.
138
138
2. Compare the current skill versions on main vs the PR branch to understand which patterns are current.
139
-
3. Resolve conflicts (prefer main's patterns for skill-generated code, the PR branch for problem-specific logic, main for regenerated artifacts like JSON).
139
+
3. Resolve **all**conflicts regardless of how many files are affected (prefer main's patterns for skill-generated code, the PR branch for problem-specific logic, main for regenerated artifacts like JSON).
140
140
4. Stage resolved files, commit, and push.
141
-
- If the report says the merge status is `conflicted` and there are too many conflicts (>3 files, or conflicts in core implementation files beyond just JSON/skill artifacts):
142
-
1. Abort the merge: `git merge --abort` if a merge is still in progress
143
-
2. Post a comment on the PR explaining the situation:
144
-
```bash
145
-
gh pr comment <PR_NUMBER> --body "This PR has significant merge conflicts with main ($(N) conflicting files). Moving the linked board item back to Ready for rework while leaving the PR open.
146
-
147
-
Conflicting files:
148
-
$(list of files)
149
-
150
-
The PR needs to be rebased on current main and conflicts resolved before it can proceed through the review pipeline."
4. Report: `PR #N has too many merge conflicts — left open and moved back to Ready for rework so project-pipeline can resume it later.`
157
-
5. STOP processing this PR.
141
+
5. Continue to the next step — the goal is to push PRs through to merge, not to bounce them back.
158
142
159
143
### 2. Fix Copilot Review Comments
160
144
@@ -346,7 +330,7 @@ Completed: 2/2 | All moved to Final review
346
330
| Worktree left behind on failure | Always clean up with `git worktree remove` in Step 5 |
347
331
| Working in main checkout | All work happens in `.worktrees/` — never modify the main checkout |
348
332
| Skipping merge with main | Always merge origin/main in Step 1a to catch conflicts before fixing comments |
349
-
|Wasting time on heavy conflicts | If >3 files conflict or core impl files are affected, leave the PR open, move the board item back to Ready, and let project-pipeline resume it|
333
+
|Giving up on conflicts too easily | Always try to resolve all conflicts. Only move back to Ready if resolution would be genuinely dangerous (e.g. irreconcilable semantic conflicts that risk breaking correctness)|
350
334
| Ignoring issue comments | Always check the linked issue (`Fix #N`) for human feedback in Step 2a |
351
335
| Only checking Copilot comments | Step 2a checks human PR reviews and linked issue comments too — bot-only review is insufficient |
352
336
| Saying "passed" while deferring issues | If anything remains for maintainer judgment, list it explicitly under `Remaining issues for final review` and mark the agentic result accordingly |
0 commit comments